-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NLohmann doesn't compile when enabling strict warning policies #1224
Comments
Putting a Keep up the great work :-)! |
There are multiple options as far as switch handling of enums, and it is impossible to make code clean to all of them at once, as one warns when there is no default case, and one warns when the default case is used when all the elements of an enum are also specified. See #889 and #555 You should be able to do the same as |
Okay that makes perfect sense! I can't include it with <json.hpp> because I need the file to be in the project folder |
I would put it in a |
Mhh. that might work as well. |
I fixed the "all member functions are private" warning. As @gregmarr wrote, there is nothing consistent we can do about warnings in switches. |
Thank you! I will close the issue now, I think all that CAN be done was done. |
Project including nlohmann doesn't compile with strict warning options:
Clean compile, no warnings
Getting following warnings:
GNU/Linux/Fedora, gcc
Did you use a released version of the library or the version from the
develop
branch?I used the newest release, as downloadable here: https://github.com/nlohmann/json/releases/download/v3.2.0/json.hpp
If you experience a compilation error: can you compile and run the unit tests?
Doesn't apply as I use the header only version.
Additional:
Strict warnings are very important to me as I want to ensure that I don't commit stupid mistakes (like we all do sometimes ;) ).
The text was updated successfully, but these errors were encountered: