Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable installation when used as meson subproject #1463

Closed
elvisoric opened this issue Jan 30, 2019 · 1 comment
Closed

Disable installation when used as meson subproject #1463

elvisoric opened this issue Jan 30, 2019 · 1 comment
Assignees
@nlohmann
Labels
release item: 🔨 further change solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Milestone
Release 3.6.0

Comments

@elvisoric
Copy link

When the library is used as Meson subproject it is included in top level project as dependency from the subproject. With current implementation of the library, when main project is installed the library is also installed which is undesirable.

Meson build script should be changed to allow installation only if the library is not used as subproject.

The installation step should be guarded with:

if not meson.is_subproject()
# steps for install headers and pkgconfig
endif
This was referenced Jan 30, 2019
Merged
Merged
nlohmann added a commit that referenced this issue Feb 10, 2019
@nlohmann
Merge pull request #1464 from elvisoric/update_meson_install_step
eee3bc0 
Disable installation when used as meson subproject. #1463
@nlohmann nlohmann self-assigned this Feb 10, 2019
@nlohmann nlohmann added this to the Release 3.5.1 milestone Feb 10, 2019
@nlohmann
Copy link
Owner

Closed by merging #1464

@nlohmann nlohmann added the solution: proposed fix a fix for the issue has been proposed and waits for confirmation label Feb 10, 2019
@eli-schwartz eli-schwartz mentioned this issue Jul 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nlohmann nlohmann

Labels
release item: 🔨 further change solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Projects
None yet
Milestone
Release 3.6.0
Development

No branches or pull requests
2 participants
@nlohmann @elvisoric