Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed broken links in the README file #1423

Merged
merged 1 commit into from
Jan 10, 2019
Merged

Fixed broken links in the README file #1423

merged 1 commit into from
Jan 10, 2019

Conversation

skypjack
Copy link
Contributor

Fixed a link to json::parse in the README file. 👍

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 6546cad on skypjack:patch-1 into 847dd2a on nlohmann:develop.

@skypjack
Copy link
Contributor Author

skypjack commented Jan 10, 2019

I don't know why the CI fails. I've modified only the README file. Any suggestion?

Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this Jan 10, 2019
@nlohmann nlohmann added this to the Release 3.5.1 milestone Jan 10, 2019
@nlohmann nlohmann merged commit df460c9 into nlohmann:develop Jan 10, 2019
@nlohmann
Copy link
Owner

Thanks!

@skypjack
Copy link
Contributor Author

You're welcome. As a side note (and not something for which I want to create a PR), you should update the copyright notes to the new year (ie the LICENSE and the others). 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants