Fix consistency in function int_to_string()

[dota17]

The function int_to_string() call std::to_string(), which will return std::string. For consistency, need to check string_type is std::string.

Refer: #2059

[coveralls]

Coverage remained the same at 100.0% when pulling 0ecf297 on dota17:issue#2059 into e7452d8 on nlohmann:develop.

[nlohmann]

What would be the previous behavior if string_type::value_type is not char? I understand now such types are excluded - but what would have happened earlier?

[dota17]

What would be the previous behavior if string_type::value_type is not char? I understand now such types are excluded - but what would have happened earlier?

If char_type is not char, there will be compiler error, the problem will arise before int_to_string, cause the library default string_type is std::string, default char_type is char. So now I might think I may not understand the issue correctly, and so far, I can't used the EASTL to reproduce the issue. The current solution is more of a temporary and partial solution, and more changes may be needed next.

[nlohmann]

I am not sure whether this change is improving the situation. Instead, we may change the function to

using std::to_string;
target = to_string(value);

to allow for ADL to choose the right function and the user-defined types to provide these functions.

[dota17]

Thanks. This suggestion is very nice.
And back to the original issue #2059, we may need more information from @bcollins526

[bcollins526]

Thanks. This suggestion is very nice.
And back to the original issue #2059, we may need more information from @bcollins526

Sure just let me know what you need.

[nlohmann]

Looks good to me.

[nlohmann]

Thanks!

[nlohmann]

---

🔖 Release item

This issue/PR will be part of the next release of the library. This template helps preparing the release notes.

Type

• ✨ New Feature
• 🐛 Bug Fix
• ⚡️ Improvement
• 🔨 Further Change
• 🔥 Deprecated function

Description

• Allow ADR inside iteration proxy. Fix consistency in function int_to_string() #2193

---