-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix consistency in function int_to_string()
#2193
Conversation
What would be the previous behavior if |
If char_type is not char, there will be compiler error, the problem will arise before |
I am not sure whether this change is improving the situation. Instead, we may change the function to using std::to_string;
target = to_string(value); to allow for ADL to choose the right function and the user-defined types to provide these functions. |
Thanks. This suggestion is very nice. |
Sure just let me know what you need. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Thanks! |
🔖 Release itemThis issue/PR will be part of the next release of the library. This template helps preparing the release notes. Type
Description
|
The function
int_to_string()
callstd::to_string()
, which will return std::string. For consistency, need to checkstring_type
isstd::string
.Refer: #2059