Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes unused variable 'ex' for #2304 #2305

Merged
merged 2 commits into from
Jul 25, 2020
Merged

fixes unused variable 'ex' for #2304 #2305

merged 2 commits into from
Jul 25, 2020

Conversation

AODQ
Copy link
Contributor

@AODQ AODQ commented Jul 23, 2020

Adds (void) to ex variables to prevent warnings when exceptions are disabled, as described in #2304 .

@AODQ AODQ requested a review from nlohmann as a code owner July 23, 2020 17:26
@coveralls
Copy link

coveralls commented Jul 23, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 15ec0fe on AODQ:develop into 43e07bb on nlohmann:develop.

@nlohmann nlohmann linked an issue Jul 24, 2020 that may be closed by this pull request
Clang 10.0 / GCC 10.1 warnings on disabled exceptions #2304
Closed
nlohmann
nlohmann approved these changes Jul 25, 2020
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann added this to the Release 3.8.1 milestone Jul 25, 2020
@nlohmann nlohmann merged commit 808aca4 into nlohmann:develop Jul 25, 2020
@nlohmann
Copy link
Owner

Thanks!

@nlohmann
Copy link
Owner

🔖 Release item

This issue/PR will be part of the next release of the library. This template helps preparing the release notes.

Type

  • ✨ New Feature
  • 🐛 Bug Fix
  • ⚡️ Improvement
  • 🔨 Further Change
  • 🔥 Deprecated function

Description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlohmann nlohmann nlohmann approved these changes

Assignees
No one assigned
Labels
release item: 🔨 further change
Projects
None yet
Milestone
Release 3.9.0
Development

Successfully merging this pull request may close these issues.

Clang 10.0 / GCC 10.1 warnings on disabled exceptions
3 participants
@AODQ @coveralls @nlohmann