Allow disabling std::filesystem support #3194
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be useful when the compiler claims C++17 support, but standard library std::filesystem implementation is unavailable (MinGW) or can't be used because the current macOS target is too low to allow it (nlohmann#3156). See nlohmann#3090.
|
The filesystem issue is fixed here: #3101 - it also implements macros |
|
Sorry for wasting your time, I've somehow failed to find #3101 which is, of course, much more complete and better than this version, thanks for pointing me to it! |
|
@vadz Thanks anyway for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be useful when the compiler claims C++17 support, but standard
library std::filesystem implementation is unavailable (MinGW) or can't
be used because the current macOS target is too low to allow it (#3156).
See #3090.
I think it could be useful to disable this by default when macOS min version target is lower than 10.15 and will add a commit doing this if there are no objections.