-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and update CI #3368
Fix and update CI #3368
Conversation
GitHub updated their runners. windows-latest is now based on Windows Server 2022 and comes with different tool versions. MSVC 2019 is still available via the windows-2019 runner.
9299c72
to
64a2e05
Compare
I've addressed |
@falbrechtskirchinger Thanks for the PR - one question: does the used compiler versions change; that is, does the table in https://github.com/nlohmann/json#supported-compilers need to be updated? |
No worries - I did not realize the CI does not work without this fix. I will merge and check the versions later. Edit: I still have a question, see below. |
The precise version might have. Need to double check. |
b7ed68d
to
64a2e05
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Thanks! I will merge once the CI is green. |
FYI: From a previous CI run:
https://github.com/nlohmann/json#supported-compilers lists:
|
Per GitHub's announcement [1] the windows-latest runner has migrated to Windows Server 2022 and ships with different tool versions. Specifically, it no longer includes MSVC 2019. Use windows-2019 instead.
The manual trigger
workflow_dispatch
has been added to all workflows allowing them to be manually triggered from the Actions tab (via the "Run Workflow" drop-down). This can be used to trigger a CI run on branches other thandevelop
,master
, orrelease/*
, and by forks prior to creating a PR.Add
topic/*
to the list of push triggers. Again, this is useful to run CI more easily during development. I've chosen a neutral name without a common prefix with other branches to not interfere with tab completion (e.g.,devel/
anddevelop
).[1] https://github.blog/changelog/2022-01-11-github-actions-jobs-running-on-windows-latest-are-now-running-on-windows-server-2022/
[2] https://github.com/actions/virtual-environments/blob/main/images/win/Windows2019-Readme.md#language-and-runtime