Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable_testing only if the JSON_BuildTests is ON #666

Merged
merged 1 commit into from
Jul 27, 2017
Merged

enable_testing only if the JSON_BuildTests is ON #666

merged 1 commit into from
Jul 27, 2017

Conversation

ilqvya
Copy link
Contributor

@ilqvya ilqvya commented Jul 27, 2017

Don't use what we don't need

nlohmann
nlohmann approved these changes Jul 27, 2017
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling a27dd3a on effolkronium:develop into 669ebf5 on nlohmann:develop.

@nlohmann nlohmann self-assigned this Jul 27, 2017
@nlohmann nlohmann added this to the Release 3.0.0 milestone Jul 27, 2017
@nlohmann nlohmann merged commit c136b6f into nlohmann:develop Jul 27, 2017
@nlohmann
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlohmann nlohmann nlohmann approved these changes

Assignees

@nlohmann nlohmann

Labels
None yet
Projects
None yet
Milestone
Release 3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ilqvya @coveralls @nlohmann