Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed compiler warning about unused variable 'kMinExp' #936

Merged
merged 1 commit into from
Jan 27, 2018
Merged

Removed compiler warning about unused variable 'kMinExp' #936

merged 1 commit into from
Jan 27, 2018

Conversation

zerodefect
Copy link
Contributor

in file 'develop/detail/conversions/to_chars.hpp'

See issue #935

nlohmann
nlohmann approved these changes Jan 25, 2018
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this Jan 25, 2018
@nlohmann nlohmann added this to the Release 3.1.0 milestone Jan 25, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.94% when pulling 95cf1fe on zerodefect:improvement/fix_kmin_compiler_warning into 355c1e9 on nlohmann:develop.

@nlohmann nlohmann merged commit 7aace7c into nlohmann:develop Jan 27, 2018
@nlohmann
Copy link
Owner

Thanks!

@nlohmann nlohmann mentioned this pull request Jan 27, 2018
Closed
nlohmann added a commit that referenced this pull request Jan 27, 2018
@nlohmann
📝 cleanup after #936
1be3935
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlohmann nlohmann nlohmann approved these changes

Assignees

@nlohmann nlohmann

Labels
None yet
Projects
None yet
Milestone
Release 3.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zerodefect @coveralls @nlohmann