Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary noise on missing config.py #683

Closed
spyysalo opened this issue Feb 3, 2012 · 3 comments
Closed

Unnecessary noise on missing config.py #683

spyysalo opened this issue Feb 3, 2012 · 3 comments

Comments

@spyysalo
Copy link
Member

spyysalo commented Feb 3, 2012

When trying to open a new brat without first creating a config.py, the following messages are shown:

Protocol error: ActiongetCollectionInformation returned the results of action undefined
Missing file config.py in the installation dir. If this is a new installation, copy the template file config_template.py to config.py in your installation directory ("cp config_template.py config.py") and edit it to suit your environment.
Protocol error: Actionwhoami returned the results of action undefined
Missing file config.py in the installation dir. If this is a new installation, copy the template file config_template.py to config.py in your installation directory ("cp config_template.py config.py") and edit it to suit your environment.
Protocol error: ActionloadConf returned the results of action undefined
Missing file config.py in the installation dir. If this is a new installation, copy the template file config_template.py to config.py in your installation directory ("cp config_template.py config.py") and edit it to suit your environment.

As the correct message ("Missing file config.py") is included, this isn't a big deal, but as this issue is likely to be frequently encountered on fresh installations, it would be nice if the output were a bit cleaner.

@ghost ghost assigned spyysalo Feb 3, 2012
@spyysalo
Copy link
Member Author

Perhaps we could create a new client-server protocol exception specific to missing configuration and have the client deal with the best way of presenting the info to the user?

@spyysalo
Copy link
Member Author

62754d4 fixes a few protocol errors, but messages seem to go missing at the moment. Also, opened #719 for the client-side issue of avoiding message duplication.

@spyysalo
Copy link
Member Author

As of 24e3ad1, the messages are also OK. Remaining bits for this are in #719 and a related issue in #720. Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant