Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boolean values #621

Closed
stevenbird opened this issue Feb 22, 2014 · 1 comment
Closed

Boolean values #621

stevenbird opened this issue Feb 22, 2014 · 1 comment
Assignees
@stevenbird
Labels
inactive nice idea pythonic
Milestone
3.3

Comments

@stevenbird
Copy link
Member

Use True and False instead of 1 and 0 for readability.
@stevenbird stevenbird added this to the nltk3beta milestone Feb 22, 2014
@stevenbird stevenbird self-assigned this Feb 22, 2014
@stevenbird stevenbird modified the milestones: nltk3 final, nltk3beta Feb 22, 2014
@stevenbird stevenbird modified the milestones: nltk 3.1, nltk3 final Apr 18, 2014
@Liechti Liechti mentioned this issue Apr 26, 2014
Merged
@Liechti
Copy link
Contributor

Liechti commented Apr 26, 2014

I took the results from
grep -rn "return [01]" .
and went through the list, dividing it into "Change" and "No Change" (see the full list here). Please a take look to see if there is more that needs to be done.

Also the documentation for the step method in the SteppingRecursiveDescentParser class should be changed from return: 0 to return: None in order to match the code.

kmike added a commit that referenced this issue May 1, 2014
@kmike
Merge pull request #664 from Liechti/develop
2742831 
Changes for Boolean Values #621
inteldict pushed a commit to inteldict/nltk that referenced this issue Jul 15, 2015
@kmike
Merge pull request nltk#664 from Liechti/develop
6f11c04 
Changes for Boolean Values nltk#621
@stevenbird stevenbird modified the milestones: 3.1, 3.2 Oct 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevenbird stevenbird

Labels
inactive nice idea pythonic
Projects
None yet
Milestone
3.3
Development

No branches or pull requests
3 participants
@stevenbird @alvations @Liechti