fix snowball stemmer bug in handling word y's
#333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
STEP 1c in line 828 checks `len(word) > 2` as last condition. However, this will cause `string index out of range` Error when stem the word `y's` since `word` will be `y` when we come to line 828. Move the condition `len(word)>2` to beginning will solve this issue.
kmike
added a commit
that referenced
this pull request
Jan 3, 2013
fix snowball stemmer bug in handling word `y's`
|
Thanks! |
alexrudnick
added a commit
that referenced
this pull request
Jan 12, 2013
Bugfix for snowball stemmer typo introduced in #333
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STEP 1c in line 828 checks
len(word) > 2as last condition. However, this will causestring index out of rangeerror when stem the wordy'ssincewordwill beywhen we come to line 828. Move the conditionlen(word)>2to beginning will solve this issue.