Skip to content

Commit

Permalink
Merge pull request #53 from megahomyak/master
Browse files Browse the repository at this point in the history
NOT closing the HTTPX Client if login wasn't successful
  • Loading branch information
megahomyak committed Mar 18, 2022
2 parents 337379d + 97bf5f3 commit 5f854b0
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion netschoolapi/netschoolapi.py
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ async def login(
method="POST"
)
except httpx.HTTPStatusError as http_status_error:
await self._wrapped_client.client.aclose()
if http_status_error.response.status_code == httpx.codes.CONFLICT:
response_json = http_status_error.response.json()
if 'message' in response_json:
Expand Down

0 comments on commit 5f854b0

Please sign in to comment.