Fix fetchGit with submodules #351
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The attrset update operator (`//`) is required to be put in parentheses otherwise the rhs isn't considered by fetchGit.
|
I just stumbled upon this PR and find it very useful. Does anything block it from being merged? |
|
Although this works nicely, i have some thought about it: If you have a niv source with Asserting that nix is newer or equal to 2.4 in case |
|
This can be closed as the other MR fixed it, right? |
|
I think so. @awidegreen I'll let you re-open if we missed something! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The attrset update operator (
//) is required to be put in parenthesesotherwise the rhs isn't considered by fetchGit.