Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated readme from release-21.05 to nixos-unstable #378

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

eyJhb
Copy link
Contributor

@eyJhb eyJhb commented Oct 9, 2023

The readme.md does not reflect how niv current handles init, as it no longer follows the release-xxx branch, but instead unstable.

This might cause confusion for some, as they will try to use release-xxx branch, which shouldn't be used (AFAIK), but if one wants to pin to a stable branch nixos-xxx or nixpkgs-xxx should be used instead :)

Copy link
Owner

@nmattia nmattia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes, that's correct! Thanks a lot!

CI will probably fail because README.md & README.tpl.md are not in sync. You can easily fix this by copying your changes to README.tpl.md, or let me know and I'll push to your branch!

@eyJhb
Copy link
Contributor Author

eyJhb commented Oct 16, 2023 via email

@eyJhb
Copy link
Contributor Author

eyJhb commented Oct 16, 2023

Should be fixed now ;)

@nmattia nmattia merged commit 723f0ee into nmattia:master Oct 17, 2023
2 checks passed
@nmattia
Copy link
Owner

nmattia commented Oct 17, 2023

Thank you @eyJhb !

@eyJhb eyJhb deleted the replace-release-with-nixos branch October 17, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants