Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default aria2c location a bit weird? #4

Closed
ilcn opened this issue Jun 25, 2017 · 2 comments
Closed

default aria2c location a bit weird? #4

ilcn opened this issue Jun 25, 2017 · 2 comments

Comments

@ilcn
Copy link

ilcn commented Jun 25, 2017

ubuntu apt installs aria2c in /usr/local/bin, maybe say that in the readme? your default aria2c location in the script is in /opt something, and if the user doesn't know to check that it the script doesn't say anything.
@nmbooker
Copy link
Owner

Hi @ilcn I'm not using this at the moment, so if you're still interested could you please review pull request #5 to check if that update is sensible.

I have checked on Ubuntu 17.04 and aria2c is in /usr/bin by default so my patch reflects that:

$ sudo apt install aria2
$ which aria2c
/usr/bin/aria2c

nmbooker added a commit that referenced this issue Dec 31, 2017
@nmbooker
[BREAKING CHANGE] Merge pull request #5 from nmbooker/update-default-…
f8fb6d1 
…aria-bin-path

Update default aria bin path for issue #4.

This may break people who rely on the defaults for installation on Debian Squeeze or other old (largely obsolete) distros.  Apologies for that but I think it's more valuable to have sane defaults going forward for more modern distros, and the init script is very much intended as an example to customise for your needs anyway.
@nmbooker nmbooker mentioned this issue Dec 31, 2017
Merged
@nmbooker
Copy link
Owner

Closed by #5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nmbooker @ilcn