-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue when creating Release through API #96
Comments
I believe this is something that was not added to the library. |
@Casz I only started using this library yesterday, and I haven't started digging into the code yet. Having the ability to set the |
https://github.com/nmklotas/GitLabApiClient/blob/master/src/GitLabApiClient/Models/Releases/Requests/CreateReleaseRequest.cs seems to only consider one use case so it will properly need to be modified |
As documented here: https://docs.gitlab.com/ee/api/releases/#create-a-release When creating a GitLab release, there is additional property called `Ref` which is used when the Tag that the Release is targeting doesn't exist yet. This Ref can be a SHA for a commit, another tag, or a branch name. In the testing that I have done, the tag_name property is still required, so I don't think we need to create any additional constructors, only have the ability to set the `Ref` property when required.
As documented here: https://docs.gitlab.com/ee/api/releases/#create-a-release When creating a GitLab release, there is additional property called `Ref` which is used when the Tag that the Release is targeting doesn't exist yet. This Ref can be a SHA for a commit, another tag, or a branch name. In the testing that I have done, the tag_name property is still required, so I don't think we need to create any additional constructors, only have the ability to set the `Ref` property when required.
As documented here: https://docs.gitlab.com/ee/api/releases/#create-a-release When creating a GitLab release, there is additional property called `Ref` which is used when the Tag that the Release is targeting doesn't exist yet. This Ref can be a SHA for a commit, another tag, or a branch name. In the testing that I have done, the tag_name property is still required, so I don't think we need to create any additional constructors, only have the ability to set the `Ref` property when required.
As documented here: https://docs.gitlab.com/ee/api/releases/#create-a-release When creating a GitLab release, there is additional property called `Ref` which is used when the Tag that the Release is targeting doesn't exist yet. This Ref can be a SHA for a commit, another tag, or a branch name. In the testing that I have done, the tag_name property is still required, so I don't think we need to create any additional constructors, only have the ability to set the `Ref` property when required.
I have just attempted to create a GitLab Release through the API when the tag doesn't currently exist on the Repository. When I did this, I got the following response in Fiddler:
Looking at the documentation, it suggests that when the tag doesn't exist, I can specify a
Ref
to point to:https://docs.gitlab.com/ee/api/releases/#create-a-release
However, I don't see anywhere in the
CreateReleaseRequest
class that maps to theRef
parameter.Does this exist somewhere? Or is this something that needs to be added to the GitLabApiClient?
The text was updated successfully, but these errors were encountered: