-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support id, path or object of groups and project #68
Conversation
Codecov Report
@@ Coverage Diff @@
## master #68 +/- ##
==========================================
+ Coverage 24.2% 33.01% +8.81%
==========================================
Files 127 122 -5
Lines 1636 1575 -61
Branches 120 0 -120
==========================================
+ Hits 396 520 +124
+ Misses 1160 1055 -105
+ Partials 80 0 -80
Continue to review full report at Codecov.
|
@nmklotas Hi Julius. I know this is a bigger PR, do you have any concerns with the changes. I know I am breaking the API a lot lately, I might look into cleaning up Milestone and Note API to be a separate API client with a interface since they are shared between Groups and Projects. See https://github.com/jdalrymple/node-gitlab/blob/master/src/core/templates/ResourceMilestones.ts. Could also adopt more of the template resources like members. I tried to align the methods. |
Hi @nmklotas I would appreciate a review or a merge 😅 Just ran into not being able to call
|
Thanks for this big beutiful PR :) sorry for the delay. I think we need to change few things.
it should have these properties:
so user can simply pass int or string and these operators would created class ProjectId object. and since we are overriding ToString() it can be used in the path & it converts automatically. what do you think? |
Sounds totally reasonable! 👍 |
You should have coloborator access for now :) , so you can work without me impeding you |
Thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops 😅
Travis CI come on gotta support dotnet core 3... |
There we go 😆 New and improved code coverage 👍 |
Docker works fine locally, but Travis and appveyor both have blocking issues. I think with appveyor using gitlab 11 which still uses postgres 9 we got closer :) |
Library should handle path encoding
Commit more often!
Okay cleaned up the branch to only handle the API cleanup. Moving the test setup fixes into a separate PR. |
@nmklotas Hope you don't mind Julius that I used my new found powers to release a new version 😄 |
Now the user of the library does not have to worry about path encoding of group and project.
I also tried to unify query parameters and requests objects and methods.
fixes #18
fixes #33
fixes #66