Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/v5 #115

Draft
wants to merge 58 commits into
base: main
Choose a base branch
from
Draft

Release/v5 #115

wants to merge 58 commits into from

Conversation

jkoenig134
Copy link
Member

No description provided.

* chore: adapt accept, reject, revoke runtime use cases

* chore: change relationship classes

* chore: adapt transmission types

* chore: rename transmission request/response types

* fix: relationships backbone response type

* chore: adapt RelationshipsController

* chore: adapt ExternalEventsProcessor

* chore: adapt the relationship use cases

* chore: adapt request response type

* chore: adapt completing incoming requests

* refactor: content type names

* feat: get relationship with audit logs, fix types

* chore: adapt outgoing request controller and use cases

* chore: adapt relationship (change) dtos

* chore: adapt request module

* chore: adapt index file

* refactor: auditLog is transport relationship member

* chore: adapt relationship getter use cases

* chore: rename use cases

* chore: adapt transport validation

* chore: adapt schemas and further renaming

* chore: rename relation creation request content file

* refactor: renaming types

* chore: adapt request consumption tests

* refactor: rename content to creation content in sendRelationship

* fix: relationship creation request type name

* chore: adapt final consumption and transport tests

* chore: adapt runtime tests

* fix: adapt changes in transport tests

* chore: adapt the new external event processor

* chore: use correct backbone version

* fix: adapt to backbone signature

* fix: await promise

* fix: update status with relationship

* refactor: move audit log to relationship cache

* refactor: merge the relationship event handlers

* fix: relationship controller flows

* refactor: relationship types

* fix: audit log deserializer

* fix: relationship event payload

* fix: get correct creation/acceptance content

* fix: only decrypt relationship if secrets available

* fix: don't use sync result in a test

* chore: remove comments / debug code

* fix: transport tests, sort audit log

* fix: consumption tests, request controller type

* refactor: remove auditLog flag in useCases

* fix: assorted fixes

* chore: update app-runtime

* fix: exports

* refactor: massively simplify DTO creation

* fix: app runtime tests

* fix: import

* fix: mandatory audit log

* fix: adapt relationship dto/dvo, remove null checks

* refactor/fix: add audit log to test factory, remove redundant method

* fix: de-duplicate functions

* fix: redo old behaviour

* fix: casing

* fix: update event behaviour

* fix: re-add some tests

* fix: make peer an address again

* refactor: mandatory payload in put

* feat: add the relationship changes to the relationship dto

* chore: add validation to outoing request controller

* refactor: relationshipCreationContent instead of CreationRequestContent

* refactor/fix: auditLog to relationshipAuditLog, add createdByDevice

* refactor: simplify RelationshipMapper

* chore: remove unused runtime error

* fix: re-add check, remove throw

* fix: add createdByDevice to relationship DTO

* refactor: cleaner function call

* test: add old relationship change tests; test for creation content

* fix: add createdByDevice to audit log method

* fix: wrong type annotations

* fix: condition in createRequestFromTemplateResponse

* fix: add createdBDevice to TestObjectFactory audit logs

* refactor: rename auditLog file

* refactor: cosmetic changes

* refactor: correct audit log in test object factory

* fix: add oldStatus

* refactor: remove empty acceptanceContents

* refactor: request/response to creation-/acceptanceContent

* chore: adapt backbone return types, type check

* fix: correctly use types

* refactor: no type extension in backboneGetRelationships

* fix: catch undefined creation content

* refactor: fail fast undefined creation content

* fix: this was supposed to be the previous commit

* refactor: add relationship prefix to audit log

* refactor: rename relationship event processor

* refactor: change checks, use JSONWrapper for creation content

* refactor: split audit log class

* fix: update import

* refactor: acceptanceContent -> creationResponseContent

* refactor: combine events

* fix: naming

* chore: bump backbone

* chore: add admin ui to compose

* fix: naming

* chore: naming

* fix: Relationships

* fix: re-add import

* fix: update types and errors

* chore: bump backbone

* fix: add enum validators

* chore: any is always nullable

* fix: pass creation content

* fix: throw error again

* chore: remove unused content

* fix: make publicCreationResponseContentCrypto required

* chore: update validate annotation

---------

Co-authored-by: Julian König <julian.koenig@js-soft.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Copy link

coderabbitai bot commented Apr 24, 2024

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

jkoenig134 and others added 22 commits May 7, 2024 11:37
* chore: comment out address check

* chore: use backbone-specific identities

* chore: complete the realm refactoring

* fix: apply backbone-specific identities

* fix: remove realm

* fix: correct regex

* chore: sort imports

* fix: update vscode settings

* fix: update schemas

* fix: specify Application.InstanceUrl

* fix: use hostname instead of baseurl

* fix: better domain regex

* fix: bump backbone to allow localhost as Application.InstanceUrl

* fix: do not export enmeshedPrefix only for tests

* fix: correct address

* chore: rename variable

---------

Co-authored-by: Timo Notheisen <timo.notheisen@js-soft.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: mkuhn <magnus.kuhn@js-soft.com>
* feat: add backbone routes to client

* feat: change relationship statuses

* feat: change audit log statuses/relationship statuses

* feat: add non-deleting routes to relationships controller

* feat: add non-deleting relationship use cases

* test: add non-deleting transport tests

* feat: add relationshipDeleted transport event

* feat: add deletion to attributes controller and relationships controller

* refactor: name relationship operation instead of response

* chore: check for an active relationship before challenge creation

* chore: check for active relationship before creating request

* refactor: relationshipDeletedEvent to ...DeletedBySelf...

* fix: status check in relationships controller before deletion

* feat: delete messages and message recipients

* Revert "Merge branch 'release/v5' into feature/relationship-termination"

This reverts commit d3f5f68, reversing
changes made to 39e81d9.

* fix: allow deciding a request on new relationship

* fix: allow creating a draft request on no relationship

* test: messaging etc. blocked after relationship termination

* chore: add relationship deletion to checkIdentity use case

* chore: apply the incoming requests controller constructor change

* fix: complete non-deleting operations in relationships controller

* chore: remove commits to relationship deletion

"Simple" commits (e. g. type modifications) remain

* test: use correct error for no active relationship for message

* chore: check for pending/active relationship before request creation

* refactor: use improved noMatchingRelationship error message

* test: add request creation for terminated relationship test

* chore: add schemas for use cases

* fix: correct schema names in use cases

* chore: updatebackbone

* chore: use backbone-specific identities

* fix: adapt variable renaming

* fix: apply backbone-specific identities

* fix: create relationship before request consumption tests

* test: check for successful relationship termination

* fix: correct reason name to ReactivationRequest

* fix: sync relationship in test

* chore: update backbone

* fix: relationships runtime test

* chore: remove reactivation

* fix: remove some more

* fix: relationshipsFacade

* chore: remove reactivation schemas

* test: more demanding address tests

* fix: remove enmeshed prefix

* refactor: rollback relationships controller changes

* feat: re-add relationship termination in relationships controller

* chore: remove reactivation core error

* test: create pending/terminated relationship in test object factory

* test: methods for creating pending/terminated relationships in integration tests

* test: add terminated relationship message controller test

* refactor: create relationship centrally in outgoing request controller describe blocks

* test: add terminated relationship outgoing requests controller test

* test: add terminated relationship incoming requests controller tests

plus small fixes

* refactor: incoming requests controller relationship check returns validation instead of throwing

* test: canAccept / canReject return validation result

* refactor: test util terminate relationship does not require relationship id

* test: terminated relationship challenge test

* fix: terminated relationship runtime test checks can decide validation

* refactor: remove second pending relationship from factory

correct the existing relationships

* refactor: add/terminate relationship test utils return type

* test: revert last relationships test change

* refactor: replace noMatchingRelationship requests error

* refactor: rename noMatchingRelationship messages error

* refactor: error messages

* fix: message controller test

* fix: error message in message controller test

* fix: error message in relationships test

* refactor: inline relationship status check

* chore: remove checkIdentity

* fix: adapt transport services

* test: "returns 'error'" in test names

* refactor: improve decide validation comment

* Fix runtime relationshipTemplateDVO test

* refactor: remove comments

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Julian König <julian.koenig@js-soft.com>
* chore: remove RelationshipCreationChangeRequestContent

* refactor: remove RelationshipChangeDTO

* refactor: adapt tests

* fix: adapt more tests

* chore: update schemas

* refactor: use ATT for attribute ids

* refactor: use did format for address strings
* feat: add invalidAttributeOwner error for canAccept of ReadAttributeRequestItemProcessor

* refactor: avoid duplicate error message

* add IdentityAttribute Value Type validation

* feat: add RelationshipAttribute Value Type validation

* feat: add RelationshipAttribute owner validation

* feat: add "only unshared IdentityAttributes can be shared" validation

* feat: add key and confidentiality validation for RelationshipAttributes

* feat: add validation for time frames

* feat: add "tags" validation for IdentityAttributeQuery

* refactor: move validation functions to validateAnswerToQuery file

* fix: IQLQuery test

* feat: add tests for attributeCreationHints of IQLQuery

* fix: IQLQuery test

* feat: add ThirdPartyRelationshipAttributeQuery Attribute Value Type and key tests

* feat: add owner validation for IdentityAttributes queried with an IQLQuery

* feat: add owner validation for ThirdPartyRelationshipAttributeQuery

* feat: add validTo and validFrom validation for ThirdPartyRelationshipAttributeQuery

* feat: add validation for thirdParty property of ThirdPartyRelationshipAttributeQuery

* fix: modify a test so that it fulfils the new validation criteria

* feat: add validation for title and description of RelationshipAttributeQuery

* feat: avoid re-sharing of RelationshipAttributes when using a RelationshipAttributeQuery

* feat: only allow to specify the Sender itself or an empty string as the owner for the RelationshipAttributeQuery

* feat: empty string not allowed as third party in query

* feat: avoid specifying same third party multiple times

* feat: remove validation for multiple third parties again

* feat: remove validation for empty string as third party

* feat: use enum ThirdPartyRelationshipAttributeQueryOwner

* fix: executeThirdPartyRelationshipAttributeQuery and content tests

* fix: runtime tests for ThirdPartyRelationshipAttributeQueryOwner

* feat: improve `owner` query for execute(ThirdParty)RelationshipAttributeQuery

* fix: usage of $or in executeThirdPartyRelationshipAttributeQuery

* feat: add validation for RelationshipAttributes with sourceAttribute

* refactor: use strings instead of regex for error messages in tests

* refactor: standardised use of Sender and Recipient in the tests

* refactor: use strings instead of regex for error messages in tests

* fix: create empty string as Attribute owner with ProposeAttributeRequestItem

* refactor: standardised use of Sender and Recipient in the tests for ProposeAttributeRequestItemProcessor

* fix: order of errors for validation of ProposeAttributeRequestItem and missing tests

* feat: add validation for mismatching RelationshipAttribute value type (Propose)

* feat: prevent sharing of outdated IdentityAttribute

* feat: prevent sharing of private ThirdPartyRelationshipAttributes

* feat: use validateAnswerToQuery function in canAccept of ProposeAttributeRequestItemProcessor

* feat: prevent sharing of outdated RepositoryAttributes and own shared IdentityAttributes (Propose)

* feat: prevent re-sharing of RelationshipAttribute (Propose)

* feat: allow empty owner and change it to Recipient (Read)

* feat: add validation for matching of attribute and query (propose)

* refactor: create file for testing the utility function

* refactor: move tests for validateAttributeMatchesWithQuery to separate file

* refactor: location of tests for utility function

* feat: change validation for tags appropriately

* feat: add validation for owner of `attribute` of CreateAttributeRequestItem

* fix: RequestModule.test for onExistingRelationship

* feat: add "only repository IdentityAttributes can be shared" validation and error-message-update

* feat: adjust error message for copies of RepositoryAttributes

* feat: changed "only repository IdentityAttributes can be shared" validation

* refactor: "only repository IdentityAttributes can be shared" validation (shareAttribute)

* feat: add ShareIdentityAttribute already shared validation

* fix: change test scenario because of new validations

* feat: ShareAttributeRequestItem a Successor (IdentityAttribute) is already shared.

* refactor: remove invalidlyAnsweredQuery error code

* feat: add ShareIdentityAttribute Predecessor is already shared validation

* feat: add ShareRelationshipAttribute validation to avoid sharing copies

* refactor: ShareIdentityAttribute change error message

* refactor: change validation test of ShareAttributeRequest

* refactor: redundant declarations for ShareAttributeRequestItemDVO tests

* feat: add RelationshipAttribute tests for ShareAttributeRequestItemProcessor

* feat: add RelationshipAttribute test for ShareAttributeRequestItem

* refactor: variable usage in tests of AttributeRequestItemProcessor

* refactor: remove unneccessary comments

* refactor:  Errormessage and code refactoring

* refactor: incorporate comments

* fix: error with prettier because of blank line

* feat: include test for ThirdPartyRelationshipAttributeQuery

* feat: add more verbose error messages

* refactor: change Attribute Value Type to lower case

* refactor: move test to more appropriate file

* feat: add validation for IQLQuery in ProposeAttributeRequestItem

* refactor: only generate needed processors

* fix: error caused by merging

* feat: incorporate comments

* fix: prettier whitespace error

* feat: incorporate review comments

* refactor: remove duplicated tests with ProposeAttributeRequestItemProcessor

* fix: prettier blank line error

* refactor: make private helpers private where possible

* fix: merge conflicts

* fix: merge conflicts again

* fix: prettier errors with blank line

* fix: thirdPartyRelationshipAttributeQueryOwner error

* fix: ThirdPartyRelationshipAttributeFlow test

* refactor: omit validation for attributeCreationHints for now

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Ruth Di Giacomo <ruth.di-giacomo@js-soft.com>
Co-authored-by: Julian König <julian.koenig@js-soft.com>
* feat: add backbone routes to client

* feat: change relationship statuses

* feat: change audit log statuses/relationship statuses

* feat: add non-deleting routes to relationships controller

* feat: add non-deleting relationship use cases

* test: add non-deleting transport tests

* feat: add relationshipDeleted transport event

* feat: add deletion to attributes controller and relationships controller

* refactor: name relationship operation instead of response

* chore: check for an active relationship before challenge creation

* chore: check for active relationship before creating request

* refactor: relationshipDeletedEvent to ...DeletedBySelf...

* fix: status check in relationships controller before deletion

* feat: delete messages and message recipients

* Revert "Merge branch 'release/v5' into feature/relationship-termination"

This reverts commit d3f5f68, reversing
changes made to 39e81d9.

* fix: allow deciding a request on new relationship

* fix: allow creating a draft request on no relationship

* test: messaging etc. blocked after relationship termination

* chore: add relationship deletion to checkIdentity use case

* chore: apply the incoming requests controller constructor change

* fix: complete non-deleting operations in relationships controller

* chore: remove commits to relationship deletion

"Simple" commits (e. g. type modifications) remain

* test: use correct error for no active relationship for message

* chore: check for pending/active relationship before request creation

* refactor: use improved noMatchingRelationship error message

* test: add request creation for terminated relationship test

* chore: add schemas for use cases

* fix: correct schema names in use cases

* chore: updatebackbone

* chore: use backbone-specific identities

* fix: adapt variable renaming

* fix: apply backbone-specific identities

* fix: create relationship before request consumption tests

* test: check for successful relationship termination

* fix: correct reason name to ReactivationRequest

* fix: sync relationship in test

* chore: update backbone

* fix: relationships runtime test

* chore: remove reactivation

* Revert "chore: remove reactivation"

This reverts commit 67d0133.

* fix: remove some more

* fix: relationshipsFacade

* chore: remove reactivation schemas

* test: more demanding address tests

* fix: remove enmeshed prefix

* refactor: rollback relationships controller changes

* feat: re-add relationship termination in relationships controller

* chore: remove reactivation core error

* test: create pending/terminated relationship in test object factory

* test: methods for creating pending/terminated relationships in integration tests

* test: add terminated relationship message controller test

* refactor: create relationship centrally in outgoing request controller describe blocks

* test: add terminated relationship outgoing requests controller test

* test: add terminated relationship incoming requests controller tests

plus small fixes

* refactor: incoming requests controller relationship check returns validation instead of throwing

* test: canAccept / canReject return validation result

* refactor: test util terminate relationship does not require relationship id

* test: terminated relationship challenge test

* fix: terminated relationship runtime test checks can decide validation

* Revert "chore: remove reactivation schemas"

This reverts commit 20c42d0.

* Revert "chore: remove reactivation core error"

This reverts commit 421eb79.

* Revert "fix: remove some more"

This reverts commit 143c648.

* Revert "fix: relationshipsFacade"

This reverts commit ac6f8fd.

* refactor: remove second pending relationship from factory

correct the existing relationships

* refactor: add/terminate relationship test utils return type

* test: revert last relationships test change

* refactor: replace noMatchingRelationship requests error

* refactor: rename noMatchingRelationship messages error

* refactor: error messages

* fix: message controller test

* fix: error message in message controller test

* fix: error message in relationships test

* refactor: inline relationship status check

* chore: backbone version bump

* fix: end2end test relationship adding

* test: add reactivation runtime tests

* feat: add reactivation/validation to relationships controller

* refactor: update not only pending relationship

* test: extend End2End test

* refactor: remove comments

* chore: add new backbone event processors

* refactor: remove comments

* fix: relationship client method names

* refactor: method name completeOperationWithBackboneCall

* fix: remove optional return types

* chore: sort imports

* fix: bump backbone

* test: add tests for added relationship validation

* chore: upgrade backbone (again)

* fix: End2End relationship tests

* chore: remove decompose

* fix: wrong ! in relationships controller

* test: add another event validation to runtime test

* refactor: add )

* test: add toBeSuccessful checks, some fixes

* test: add transport test for relationship reactivation request

* refactor: name requestRelationshipReactivation

* chore: add status checks to relationship use cases

* test: check audit log reason instead of new status

* refactor: codeshare

* chore: upgrade backbone again

* refactor: add relationshipId to error messages

* refactor: remove duplicate relationship validations

* test: remove additional relationship status checks

* test: add noRecordFound relationship tests

* Revert "refactor: remove duplicate relationship validations"

This reverts commit 3d01a42.

* refactor: remove status checks

* test: add relationship tests

* fix: errors in tests

* refactor: move relationship termination sync in test

* refactor: separate negative tests

* refactor: new events for relationship reactivation

* fix: follow-up to new events

* refactor: rename relationship tests

* refactor: newline

* fix: re-add relationship changed event

* test: re-add relationship changed events to tests

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Julian König <julian.koenig@js-soft.com>
* chore: bump all versions to 5.0.0-alpha.1

* chore: update package.lock

* chore: undo the iql breaking bump

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Milena-Czierlinski and others added 25 commits July 2, 2024 09:43
* feat: allow to share an already shared attribute that is deleted by peer

* fix: expect result

* feat: also allow status ToBeDeletedByPeer

* feat: adjust ShareRepositoryAttribute use case

* chore: version bump

* chore: remove unused error

* chore: bump peer dependency
* chore: bump bkb version

* chore: update config
* fix: use empty owner for CreateAttributeRequestItem

* chore: add pull:backbone script

* fix: accept more statuses for creating an incoming request

* fix: always return the newest relationship

out database layers do not do any sorting so we have to do that

* chore: remove wrong type

* chore: add version bumps

---------

Co-authored-by: Julian König <julian.koenig@js-soft.com>
* refactor: rename functions more descriptive

* fix: reset event bus
* refactor: remove mustBeAccepted of RequestItemGroup

* fix: make runtime tests work

* refactor: rename error message from parent to Request

* chore: remove outdated comments

* chore: build schemas

* feat: add tests again that were removed firstly

* refactor: define reusable auxiliary function for RequestItemDerivations

* chore: version bumps of consumption, content and runtime

* fix: correct indexPath typo

* fix: undo unneccessary "fix"

* feat: incorporate review comments

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* chore: add decompose to facade

* test: add decompose runtime tests (WIP)

* test: add decompose runtime tests

* refactor: fewer deletion events/name deleteRecipientInMessage

* refactor: variable name anonymizedMessage

* test: add a non-decomposed control to test

* fix: correct reason name to ReactivationRequest

* fix: sync relationship in test

* chore: update backbone

* fix: relationships runtime test

* chore: remove reactivation

* Revert "chore: remove reactivation"

This reverts commit 67d0133.

* fix: remove some more

* fix: relationshipsFacade

* chore: remove reactivation schemas

* test: more demanding address tests

* fix: remove enmeshed prefix

* refactor: rollback relationships controller changes

* feat: re-add relationship termination in relationships controller

* chore: remove reactivation core error

* test: create pending/terminated relationship in test object factory

* test: methods for creating pending/terminated relationships in integration tests

* test: add terminated relationship message controller test

* refactor: create relationship centrally in outgoing request controller describe blocks

* test: add terminated relationship outgoing requests controller test

* test: add terminated relationship incoming requests controller tests

plus small fixes

* refactor: incoming requests controller relationship check returns validation instead of throwing

* test: canAccept / canReject return validation result

* refactor: test util terminate relationship does not require relationship id

* test: terminated relationship challenge test

* fix: terminated relationship runtime test checks can decide validation

* Revert "chore: remove reactivation schemas"

This reverts commit 20c42d0.

* Revert "chore: remove reactivation core error"

This reverts commit 421eb79.

* Revert "fix: remove some more"

This reverts commit 143c648.

* Revert "fix: relationshipsFacade"

This reverts commit ac6f8fd.

* refactor: remove second pending relationship from factory

correct the existing relationships

* refactor: add/terminate relationship test utils return type

* test: revert last relationships test change

* refactor: replace noMatchingRelationship requests error

* refactor: rename noMatchingRelationship messages error

* refactor: error messages

* fix: message controller test

* fix: error message in message controller test

* fix: error message in relationships test

* refactor: inline relationship status check

* chore: backbone version bump

* fix: end2end test relationship adding

* test: add reactivation runtime tests

* feat: add reactivation/validation to relationships controller

* refactor: update not only pending relationship

* test: extend End2End test

* refactor: remove comments

* chore: add new backbone event processors

* refactor: remove comments

* fix: relationship client method names

* refactor: method name completeOperationWithBackboneCall

* fix: remove optional return types

* chore: sort imports

* fix: bump backbone

* test: add tests for added relationship validation

* chore: upgrade backbone (again)

* chore: add decompose to relationship client

* fix: remove realm

* refactor: remove test skips

* fix: End2End relationship tests

* chore: remove decompose

* fix: wrong ! in relationships controller

* test: add another event validation to runtime test

* refactor: add )

* test: add toBeSuccessful checks, some fixes

* test: add transport test for relationship reactivation request

* refactor: name requestRelationshipReactivation

* chore: add status checks to relationship use cases

* test: check audit log reason instead of new status

* refactor: codeshare

* chore: upgrade backbone again

* refactor: add relationshipId to error messages

* refactor: remove duplicate relationship validations

* test: remove additional relationship status checks

* test: add noRecordFound relationship tests

* Revert "refactor: remove duplicate relationship validations"

This reverts commit 3d01a42.

* refactor: remove status checks

* test: add relationship tests

* fix: errors in tests

* fix: End2End test syntax errors

* chore: add decomposition to relationship status/audit log types

* fix: adapt relationships controller

* test: add some decomposition tests

* fix: End2End test

* refactor: move relationship termination sync in test

* fix: delete attributes during decomposition

* fix: queries for to be deleted objects

* refactor: shorten message controller

* fix: relationships test

* refactor: separate negative tests

* refactor: new events for relationship reactivation

* fix: follow-up to new events

* refactor: rename relationship tests

* fix/refactor: complete relationship decomposed event

* refactor: newline

* fix: re-add relationship changed event

* test: re-add relationship changed events to tests

* fix: recipientDTO has optional relationship

* chore: delete relationship template during decompose

* fix: module import in relationships test

* Revert "fix: module import in relationships test"

This reverts commit 185d471.

* fix: module import in relationships test

* feat: add pseudonymization

* fix: throw on error

* fix: throw on more errors

* fix: relationships test for templates

* refactor: cleaner pseudonymization

* fix: delete relationshipId

* chore: backbone version bump

* refactor: separate runtime  and backbone relationship status

* test: skip message tests

* fix: relationshipstatus to backbonerelationshipstatus

* fix: relattionshipstatus DVE import

* fix: relationshipstatus test utils

* fix: relationshipstatus tests

* refactor: remove messageRecipientDeleted event

* chore: backbone bump

* fix: renamings, asyncs, no skipped tests

* Revert "fix: relationshipstatus tests"

This reverts commit 9cdf5ed.

* Revert "fix: relationshipstatus test utils"

This reverts commit 30c7354.

* Revert "fix: relattionshipstatus DVE import"

This reverts commit 8784cb7.

* Revert "fix: relationshipstatus to backbonerelationshipstatus"

This reverts commit aa0be62.

* Revert "refactor: separate runtime  and backbone relationship status"

This reverts commit 1344b0f.

* refactor: remove message content pseudonymization

* refactor: namings, imports

* test: remove failing pseudonymization tests

* fix: apply changed naming

* fix: apply changed naming

* refactor: move pseudonym to process.env

* chore: log instead of error in decompose

* refactor: remove awaits

* refactor: move decompose into controllers

* refactor: notificationsWith -> notificationsExchangedWith

* fix: remove await

* feat: add CachedMessageRecipient, remove relationshipIds

* fix: remove pseudonym

* refactor: udpate mapper

* refactor: update controller

* refactor: naming

* chore: remove unused vars declaration

* refactor: delete data from all collections

* chore: remove comment that is now invalid

* chore: simplify query

* fix: resolve the peer instead of the recipient

* fix: update test with anonymizations

* chore: uncomment test

* refactor: split decompose and cleanup

* chore: delete message with 1 recipient

* chore: resolve comments

* chore: naming & easier reading

* fix: decompose in status deletionProposed possible

* fix: better syntax

* test: add message controller tests

* refactor: cleanup way more stuff / align naming

* chore: formatting

* chore: formatting imports and stuff

* chore: re-add comment

* fix: e2e

* fix: re-apply message cache updates after deletion

* test: move decomposition to extra file

* refactor: make behaviour more failure-proof

* chore: formatting

* fix: async jest

* chore: version bumps

* chore: build schemas

* fix: typo

* refactor: un-parallelize deletions

* fix: missing await

* refactor: use for

* chore: naming

* fix: update doomed message tests

* refactor: update message decrypt logic

* fix: remove cleanupping files

* chore: update error message

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Julian König <julian.koenig@js-soft.com>
* refactor: remove sync callbacks from transport

* refactor: remove sync callbacks from runtime

* chore: remove export

* chore: update schemas

* chore: audit fix

* chore: audit exclude

* chore: remove doomed test
* chore: use did schema

* chore: use did schema
* fix: use void for decompose

* fix: use void in the facade

* chore: version bumps
* fix: do not use string as event data

* chore: version bump

* chore: change on callee side

* fix: test

* ci: downgrade node
…200)

* refactor: update error messages without logging addresses

* fix: provide addressGenerationBaseUrlOverride to make sure to match the backbones identity

* chore: version bumps

* chore: better naming

* refactor: simplify error output
* fix: remove enmeshed prefix

* refactor: rollback relationships controller changes

* feat: re-add relationship termination in relationships controller

* chore: remove reactivation core error

* test: create pending/terminated relationship in test object factory

* test: methods for creating pending/terminated relationships in integration tests

* test: add terminated relationship message controller test

* refactor: create relationship centrally in outgoing request controller describe blocks

* test: add terminated relationship outgoing requests controller test

* test: add terminated relationship incoming requests controller tests

plus small fixes

* refactor: incoming requests controller relationship check returns validation instead of throwing

* test: canAccept / canReject return validation result

* refactor: test util terminate relationship does not require relationship id

* test: terminated relationship challenge test

* fix: terminated relationship runtime test checks can decide validation

* Revert "chore: remove reactivation schemas"

This reverts commit 20c42d0.

* Revert "chore: remove reactivation core error"

This reverts commit 421eb79.

* Revert "fix: remove some more"

This reverts commit 143c648.

* Revert "fix: relationshipsFacade"

This reverts commit ac6f8fd.

* refactor: remove second pending relationship from factory

correct the existing relationships

* refactor: add/terminate relationship test utils return type

* test: revert last relationships test change

* refactor: replace noMatchingRelationship requests error

* refactor: rename noMatchingRelationship messages error

* refactor: error messages

* fix: message controller test

* fix: error message in message controller test

* fix: error message in relationships test

* refactor: inline relationship status check

* chore: backbone version bump

* fix: end2end test relationship adding

* test: add reactivation runtime tests

* feat: add reactivation/validation to relationships controller

* refactor: update not only pending relationship

* test: extend End2End test

* refactor: remove comments

* chore: add new backbone event processors

* refactor: remove comments

* fix: relationship client method names

* refactor: method name completeOperationWithBackboneCall

* fix: remove optional return types

* chore: sort imports

* fix: bump backbone

* test: add tests for added relationship validation

* chore: upgrade backbone (again)

* chore: add decompose to relationship client

* fix: remove realm

* refactor: remove test skips

* fix: End2End relationship tests

* chore: remove decompose

* fix: wrong ! in relationships controller

* test: add another event validation to runtime test

* refactor: add )

* test: add toBeSuccessful checks, some fixes

* test: add transport test for relationship reactivation request

* refactor: name requestRelationshipReactivation

* chore: add status checks to relationship use cases

* test: check audit log reason instead of new status

* refactor: codeshare

* chore: upgrade backbone again

* refactor: add relationshipId to error messages

* refactor: remove duplicate relationship validations

* test: remove additional relationship status checks

* test: add noRecordFound relationship tests

* Revert "refactor: remove duplicate relationship validations"

This reverts commit 3d01a42.

* refactor: remove status checks

* test: add relationship tests

* fix: errors in tests

* fix: End2End test syntax errors

* chore: add decomposition to relationship status/audit log types

* fix: adapt relationships controller

* test: add some decomposition tests

* fix: End2End test

* refactor: move relationship termination sync in test

* fix: delete attributes during decomposition

* fix: queries for to be deleted objects

* refactor: shorten message controller

* fix: relationships test

* refactor: separate negative tests

* refactor: new events for relationship reactivation

* fix: follow-up to new events

* refactor: rename relationship tests

* fix/refactor: complete relationship decomposed event

* refactor: newline

* fix: re-add relationship changed event

* test: re-add relationship changed events to tests

* fix: recipientDTO has optional relationship

* chore: delete relationship template during decompose

* fix: module import in relationships test

* Revert "fix: module import in relationships test"

This reverts commit 185d471.

* fix: module import in relationships test

* feat: add pseudonymization

* fix: throw on error

* fix: throw on more errors

* fix: relationships test for templates

* refactor: cleaner pseudonymization

* fix: delete relationshipId

* chore: backbone version bump

* refactor: separate runtime  and backbone relationship status

* test: skip message tests

* fix: relationshipstatus to backbonerelationshipstatus

* fix: relattionshipstatus DVE import

* fix: relationshipstatus test utils

* fix: relationshipstatus tests

* refactor: remove messageRecipientDeleted event

* chore: backbone bump

* fix: renamings, asyncs, no skipped tests

* Revert "fix: relationshipstatus tests"

This reverts commit 9cdf5ed.

* Revert "fix: relationshipstatus test utils"

This reverts commit 30c7354.

* Revert "fix: relattionshipstatus DVE import"

This reverts commit 8784cb7.

* Revert "fix: relationshipstatus to backbonerelationshipstatus"

This reverts commit aa0be62.

* Revert "refactor: separate runtime  and backbone relationship status"

This reverts commit 1344b0f.

* refactor: remove message content pseudonymization

* refactor: namings, imports

* test: remove failing pseudonymization tests

* fix: apply changed naming

* fix: apply changed naming

* refactor: move pseudonym to process.env

* chore: log instead of error in decompose

* refactor: remove awaits

* refactor: move decompose into controllers

* refactor: notificationsWith -> notificationsExchangedWith

* fix: remove await

* feat: add CachedMessageRecipient, remove relationshipIds

* fix: remove pseudonym

* refactor: udpate mapper

* refactor: update controller

* refactor: naming

* chore: remove unused vars declaration

* refactor: delete data from all collections

* chore: remove comment that is now invalid

* chore: simplify query

* fix: resolve the peer instead of the recipient

* fix: update test with anonymizations

* chore: uncomment test

* refactor: split decompose and cleanup

* chore: delete message with 1 recipient

* chore: resolve comments

* chore: naming & easier reading

* fix: decompose in status deletionProposed possible

* fix: better syntax

* test: add message controller tests

* refactor: cleanup way more stuff / align naming

* chore: formatting

* chore: formatting imports and stuff

* chore: re-add comment

* fix: e2e

* fix: re-apply message cache updates after deletion

* test: move decomposition to extra file

* refactor: make behaviour more failure-proof

* chore: formatting

* fix: async jest

* chore: version bumps

* chore: build schemas

* fix: typo

* refactor: un-parallelize deletions

* fix: missing await

* refactor: use for

* test: add consumption tests for decompose

* ffix: readd requestItemProcessors

* fix: clear consumption decompose in testutil

* chore: naming

* fix: update doomed message tests

* refactor: update message decrypt logic

* fix: remove cleanupping files

* chore: update error message

* refactor: id2 -> did:e:...

* test: address test regex

* fix: test name

* test: add transport decompose tests

* refactor: move and skip the files test

* fix: allow both undefined and null in test

* refactor: remove skipped test

* test: add tests

* fix: test syntax error

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Julian König <julian.koenig@js-soft.com>
* feat: add backbone routes

* fix: only set for backbone client

* feat: add setting communication language

* refactor: remove comment

* refactor: remove comment

* fix: use iso639 language

* fix/test: use iso639 validation properly

* chore: version bump

* test: also check error message

* refactor: variable renaming

* refactor: enum as input

* refactor: name updateDevice

* test: add negative tests

* chore: version bump

* fix: error handling

* fix: use correct client

* test: fix expected error message

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Julian König <julian.koenig@js-soft.com>
Co-authored-by: Julian König <33655937+jkoenig134@users.noreply.github.com>
* refactor/delete unused errors and rename errors

* refactor: change SentNotification in SaveSentNotification

* feat: add a test in notifications.test.ts

* fix: error-message

* refactor: rephrasing of error messages

* chore: version bump

* refactor: more rephrasing of error messages

* fix: error message in test

* fix: change error message in test

* refactor: rechange error message

* refactor: last changes in error messages

* refactor: rechange saveSentNotification and version bump

* fix: DeviceDeletion.test

* refactor: further changes

* chore: version bump

* refactor: some other changes

* chore: version bump

* chore: version bump

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Julian König <33655937+jkoenig134@users.noreply.github.com>
* fix: don't allow array for isTechnical but allow array for parentId

* chore: version bump
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants