-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/Adjust use cases to deletionInfo #155
Fix/Adjust use cases to deletionInfo #155
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Tip Early access features: enabledWe are currently testing the following features in early access:
Note:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
packages/runtime/src/useCases/consumption/attributes/ShareRepositoryAttribute.ts
Outdated
Show resolved
Hide resolved
packages/runtime/src/useCases/consumption/attributes/ShareRepositoryAttribute.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…hd/runtime into fix/adjust-use-cases-to-deletioninfo
no version bump? |
Currently the ShareRepositoryAttribute isn't used, however, if we want to do so, it should be allowed to share a RepositoryAttribute again with the same peer in case the peer deleted it. Note that building the Request manually, as we currently do, there is no check for already shared copies.
Regarding the succession use cases, we don't have to consider any new edge cases, since if an Attribute is deleted, also all its predecessors are deleted.