Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/Merge main into v5 #164

Closed
wants to merge 11 commits into from

Conversation

Milena-Czierlinski
Copy link
Contributor

No description provided.

RuthDiG and others added 11 commits June 7, 2024 11:22
* refactor: email validation

* fix: Email-Validation and add a test for it

* fix: Website Validation and add a test for it

* feat: change regexp from Url

* chore: version bump

* refactor: test for website

* refactor: changed wording of the test

* refactor: Tests for Email and Website

* refactor: change string in regexp

* refactor: test for Website and AbstractURL

* refactor: name and AbstractURL without escape

* refactor: Change Tests and RegExp

* chore: version bump

* feat: make regexp more readable

* fix: changed an error

* fix: error and last changes

* feat: last changes

* chore: version bump

* fix: delete unnecessary file

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* feat: add deletionStatus DeletionRequestSent and DeletionRequestRejected

* fix: remove deletionInfo from GetRepositoryAttributesRequestQuery

* feat: add deleteAttributeRequestItem to RequestItemDerivations

* test: deletionInfo is set

* fix: set deletionInfo

* feat: set DeletionRequestRejected

* chore: version bump

* fix: make test more precise

* refactor: renamse RequestIntegration.test.ts

* feat: check for deletionStatus of predecessors

* feat: only set deletionInfo after Request is sent, also set deletionInfo for predecessors

* feat: undo renaming

* fix: stabilize test

* fix: stabilize all tests

* fix: npm audit

* feat: integrate comments

* feat: integrate all comments

* refactor: give more descriptive names

* chore: version bump

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* feat: add todo

* feat: ensure Attribute wasn't deleted by peer before answering ReadAttributeRequestItem with AttributeAlreadySharedAcceptResponseItem

* feat: ensure Attribute wasn't deleted by peer before answering ReadAttributeRequestItem with AttributeSuccessionAcceptResponseItem

* refactor: rename variables

* feat: check deletionInfo before creating AcceptResponseItem for ProposeAttributeRequestItem

* chore: version bump

* feat: adjust error message and add tests

* fix: make sourceAttribute required in CreateSharedLocalAttributeCopyParamsJSON

* feat: integrate comments

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Copy link

coderabbitai bot commented Jun 18, 2024

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Milena-Czierlinski Milena-Czierlinski marked this pull request as ready for review June 18, 2024 13:17
@jkoenig134
Copy link
Member

This is not how we update release branches - @Milena-Czierlinski I'll call ya :)

@jkoenig134 jkoenig134 closed this Jun 25, 2024
@jkoenig134 jkoenig134 deleted the chore/merge-main-into-v5 branch June 28, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants