Install vendor tools before call them #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinqon
force-pushed
the
install-vendor-tools
branch
from
52fc4c9
to
d5da229
Compare
phoracek
previously approved these changes
Jun 21, 2019
SchSeba
approved these changes
Jun 21, 2019
SchSeba
suggested changes
Jun 21, 2019
qinqon
force-pushed
the
install-vendor-tools
branch
from
d5da229
to
0870ae8
Compare
Use go run to run vendored tools is very convenient but it's checking a lot of cached stuff before calling, we know that we just depend on vendor version of stuff so we cann install them locally in the repo and call it. Signed-off-by: Quique Llorente <ellorent@redhat.com>
qinqon
force-pushed
the
install-vendor-tools
branch
from
0870ae8
to
d5faca1
Compare
phoracek
approved these changes
Jun 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use go run to run vendored tools is very convenient but it's
checking a lot of cached stuff before calling, we know that
we just depend on vendor version of stuff so we cann install them
locally in the repo and call it.
Signed-off-by: Quique Llorente ellorent@redhat.com