Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bond: Handle multicast mac address of ad_actor_system #1618

Merged
merged 2 commits into from
Jun 2, 2021

Conversation

cathay4t
Copy link
Member

@cathay4t cathay4t commented Jun 1, 2021

Raise NmstateValueError when desire state is using an IANA multicast MAC
address(with prefix of 01-00-5E) as bond ad_actor_system option.

Integration test case included.

@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #1618 (6e9fda4) into base (1101bb0) will decrease coverage by 1.18%.
The diff coverage is 100.00%.

❗ Current head 6e9fda4 differs from pull request most recent head ce3263b. Consider uploading reports for the commit ce3263b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             base    #1618      +/-   ##
==========================================
- Coverage   91.49%   90.30%   -1.19%     
==========================================
  Files          86       78       -8     
  Lines        6804     6218     -586     
==========================================
- Hits         6225     5615     -610     
- Misses        579      603      +24     
Impacted Files Coverage Δ
libnmstate/ifaces/bond.py 96.37% <100.00%> (-1.36%) ⬇️
libnmstate/nm/ethtool.py 62.50% <0.00%> (-31.25%) ⬇️
libnmstate/ifaces/ethtool.py 71.42% <0.00%> (-28.58%) ⬇️
libnmstate/nm/wired.py 76.47% <0.00%> (-23.53%) ⬇️
libnmstate/ifaces/ethernet.py 72.54% <0.00%> (-23.53%) ⬇️
libnmstate/ifaces/infiniband.py 74.07% <0.00%> (-22.23%) ⬇️
libnmstate/nm/translator.py 73.77% <0.00%> (-19.68%) ⬇️
libnmstate/ifaces/ovs.py 82.39% <0.00%> (-12.68%) ⬇️
libnmstate/ifaces/team.py 68.96% <0.00%> (-10.35%) ⬇️
libnmstate/ifaces/macvlan.py 88.23% <0.00%> (-8.83%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1101bb0...ce3263b. Read the comment docs.

Copy link
Member

@ffmancera ffmancera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

@ffmancera ffmancera added Waiting_Rebase Current PR is approved, but waiting rebase. and removed Wait_Review labels Jun 2, 2021
Raise NmstateValueError when desire state is using an IANA multicast MAC
address(with prefix of `01-00-5E`) as bond `ad_actor_system` option.

Integration test case included.

Signed-off-by: Gris Ge <fge@redhat.com>
@cathay4t cathay4t enabled auto-merge (rebase) June 2, 2021 13:49
@kubevirt-bot
Copy link
Collaborator

@cathay4t: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-nmstate-integ_tier1-k8s 10a51cc link /test pull-nmstate-integ_tier1-k8s

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cathay4t cathay4t merged commit 57f9740 into nmstate:base Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Waiting_Rebase Current PR is approved, but waiting rebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants