ip: Fix routes on empty address #2677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cathay4t
force-pushed
the
fix_route_empty_address
branch
from
3664df6
to
431f5c0
Compare
Nmstate fails when applying below state:
```yml
---
routes:
config:
- destination: 198.51.100.0/24
metric: 150
next-hop-interface: eth1
table-id: 254
interfaces:
- name: eth1
type: ethernet
state: up
ipv4:
enabled: true
address: []
```
The error message is:
NmstateError: InvalidArgument: The next hop interface of desired Route
'destination: 198.51.100.0/24 next-hop-interface: eth1 metric: 150
table-id: 254' has been marked as IPv4 disabled
The root cause is nmstate try to set `ipv4.enabled` to false when got
empty address, this then lead to incorrect validation.
To fix this issue, removed the sanitize on setting `ipv4.enabled` to
false on empty address, but ignore `ipvX.enabled` in validation stage
when got empty IP address list.
Integration test case updated.
Signed-off-by: Gris Ge <fge@redhat.com>
cathay4t
force-pushed
the
fix_route_empty_address
branch
from
431f5c0
to
1d3f484
Compare
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
liangwen12year
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nmstate fails when applying below state:
The error message is:
The root cause is nmstate try to set
ipv4.enabledto false when gotempty address, this then lead to incorrect validation.
To fix this issue, removed the sanitize on setting
ipv4.enabledtofalse on empty address, but ignore
ipvX.enabledin validation stagewhen got empty IP address list.
Integration test case updated.