Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base iface: Provide permanent-mac-address when querying #2692

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

cathay4t
Copy link
Member

@cathay4t cathay4t commented Jun 4, 2024

No test required as this is query only property and CI(container) has no
real NIC with this property set.

Manually tested in VM virtio_net NIC.

Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/nmstate-nmstate-2692
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@liangwen12year
Copy link
Collaborator

liangwen12year commented Jun 4, 2024

The CI is broken by the patch, when serializing the net_state, permanent-mac-address is not recognized or interpreted as the unknown field, please check it.

@cathay4t cathay4t force-pushed the expose_permanent_mac branch 2 times, most recently from 9607b05 to 30ea1b9 Compare June 12, 2024 01:21
@cathay4t
Copy link
Member Author

The CI is broken by the patch, when serializing the net_state, permanent-mac-address is not recognized or interpreted as the unknown field, please check it.

Fixed. Thanks!

@cathay4t cathay4t enabled auto-merge (rebase) June 13, 2024 02:45
@cathay4t cathay4t force-pushed the expose_permanent_mac branch 2 times, most recently from d42ee6d to 0f97095 Compare June 13, 2024 03:05
No test required as this is query only property and CI(container) has no
real NIC with this property set.

Manually tested in VM `virtio_net` NIC.

Signed-off-by: Gris Ge <fge@redhat.com>
@cathay4t cathay4t merged commit 9d0f8c0 into nmstate:base Jun 13, 2024
26 of 27 checks passed
@cathay4t cathay4t deleted the expose_permanent_mac branch June 13, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants