New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

small changes to improve usability #5

Merged

nmwsharp merged 3 commits into nmwsharp:master from xelatihy:master

Mar 1, 2019

Contributor

xelatihy commented Mar 1, 2019

Make a few small changes to more easily use the library. All changes are backward compatible and have been tested on various ply files.

inlined LICENSE to allow for single-file download
add method 'hasPropertyto check whether an element has a property before pulling it withgetProperty`
add const references in the API when possible to (a) reduce string copies and (b) allow usage if const std::vectors are used in client code

xelatihy added 3 commits

March 1, 2019 09:48


          embed license information in header file

8c64263


          added property check

be40ab1


          added const references where possible

1a0a886

Owner

nmwsharp commented Mar 1, 2019

Looks good, thanks for the contribution!

nmwsharp merged commit 21c6b14 into nmwsharp:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet