Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App: Seperate pipeline pause and close #35

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

niley7464
Copy link
Contributor

@niley7464 niley7464 commented Jun 10, 2024

This patch seperates pipeline pause and close.
Also, now we can see pipeline status in main activity.

This PR needs nnstreamer/nnstreamer#4488

@wooksong
Copy link
Member

What do the error messages above mean? Is pause->close OK, but stop isn't?

@niley7464
Copy link
Contributor Author

niley7464 commented Jun 13, 2024

What do the error messages above mean? Is pause->close OK, but stop isn't?

I left the explanation too abstractly.

I called ml_pipeline_start-> ml_pipeline_stop (pause) -> ml_pipeline_start

Then, restared server recived data like below.

2024-06-13 12:45:57.783 22590-22666 nnstreamer-edge         ai....eamer.ml.inference.offloading  D  Received command:0 (num:0)
2024-06-13 12:45:57.784 22590-22666 nnstreamer-edge         ai....eamer.ml.inference.offloading  E  Failed to get host info.
2024-06-13 12:45:57.784 22590-22666 nnstreamer-edge         ai....eamer.ml.inference.offloading  D  Send error cmd to close connection.

Data should have command enum and memory number like this.

2024-06-13 12:48:29.742 22884-22977 nnstreamer-edge         ai....eamer.ml.inference.offloading  D  Received command:2 (num:1)
2024-06-13 12:48:29.758 22884-22982 nnstreamer-edge         ai....eamer.ml.inference.offloading  D  Received command:1 (num:1)

So I thought the error message appeared when ml_pipeline_close called in PR description might be the cause.

+) The problem was not exactly related to the close function, caps were not set when restarting.

@niley7464 niley7464 marked this pull request as ready for review June 14, 2024 05:23
@niley7464 niley7464 changed the title App: Seperate pipeline pause and close [After #37] App: Seperate pipeline pause and close Jun 14, 2024
@niley7464 niley7464 changed the title [After #37] App: Seperate pipeline pause and close App: Seperate pipeline pause and close Jun 14, 2024
@niley7464 niley7464 reopened this Jun 17, 2024
Copy link
Member

@wooksong wooksong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to add submodule's changes.

This patch seperates pipeline pause an close.
Also, now we can see pipeline status in main activity.

Signed-off-by: Yelin Jeong <yelini.jeong@samsung.com>
@niley7464 niley7464 force-pushed the pipeline/pause branch 2 times, most recently from 155d84c to daa563f Compare June 19, 2024 02:44
@niley7464
Copy link
Contributor Author

We don't need to add submodule's changes.

Removed submoudle's new commit.
Thank you :)

@wooksong wooksong merged commit 7f6cad8 into nnstreamer:main Jun 21, 2024
2 checks passed
@niley7464 niley7464 deleted the pipeline/pause branch June 24, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants