[query] Set tensor query caps when state changes from PAUSED to PLAYING #4488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niley7464
requested review from
myungjoo,
jijoongmoon,
again4you,
jaeyun-jung,
wooksong,
gichan-jang,
anyj0527,
songgot,
jihochu,
yeonykim2 and
a team
as code owners
myungjoo
reviewed
Jun 14, 2024
| @@ -304,6 +304,7 @@ gst_tensor_query_serversrc_change_state (GstElement * element, | |||
| case GST_STATE_CHANGE_PLAYING_TO_PAUSED: | |||
| src->playing = FALSE; | |||
| gst_tensor_query_server_release_edge_handle (src->src_id); | |||
| src->configured = FALSE; | |||
There was a problem hiding this comment.
Care to explain? (in the commit message?)
There was a problem hiding this comment.
Updated commit message.
It seems easier to understand to set caps again in change_state callback like serversink.
So the code has also been updated.
Thank you :)
This patch makes to set tensor query caps, when state changes from PAUSED to PLAYING. When the tensor_query_server is stopped, edge_handle is released. So we need to set caps again when restarted. If caps are not set, client connection is not possible after restart tensor_query_server. Signed-off-by: Yelin Jeong <yelini.jeong@samsung.com>
jaeyun-jung
reviewed
Jun 17, 2024
jaeyun-jung
approved these changes
Jun 17, 2024
myungjoo
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes to set tensor query caps, when state changes from PAUSED to PLAYING.
When the tensor_query_server is stopped, edge_handle is released.
So we need to set caps again when restarted.
If caps are not set, client connection is not possible after restart tensor_query_server.
This PR fixes nnstreamer/nnstreamer-android#35 (comment)
Self evaluation: