-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
filter:pytorch: armhf error in PPA (print format) #3699
Conversation
Fix the print format string error: ``` In file included from /usr/include/glib-2.0/glib.h:62:0, from ../gst/nnstreamer/nnstreamer_log.h:75, from /<<PKGBUILDDIR>>/ext/nnstreamer/tensor_filter/tensor_filter_pytorch.cc:29: /<<PKGBUILDDIR>>/ext/nnstreamer/tensor_filter/tensor_filter_pytorch.cc: In member function ‘int TorchCore::validateOutputTensor(at::Tensor, unsigned int)’: /usr/include/glib-2.0/glib/gmessages.h:336:43: error: format ‘%ld’ expects argument of type ‘long int’, but argument 5 has type ‘gsize {aka unsigned int}’ [-Werror=format=] __VA_ARGS__) ^ ../gst/nnstreamer/nnstreamer_log.h:79:17: note: in expansion of macro ‘g_critical’ #define ml_loge g_critical ^~~~~~~~~~ /<<PKGBUILDDIR>>/ext/nnstreamer/tensor_filter/tensor_filter_pytorch.cc:348:5: note: in expansion of macro ‘ml_loge’ ml_loge ("Invalid output meta: different element size at index %d. Found size %ld while expecting size %ld. Update the tensor shape/size to resolve the error.", ^~~~~~~ /usr/include/glib-2.0/glib/gmessages.h:336:43: error: format ‘%ld’ expects argument of type ‘long int’, but argument 6 has type ‘gsize {aka unsigned int}’ [-Werror=format=] __VA_ARGS__) ^ ../gst/nnstreamer/nnstreamer_log.h:79:17: note: in expansion of macro ‘g_critical’ #define ml_loge g_critical ^~~~~~~~~~ /<<PKGBUILDDIR>>/ext/nnstreamer/tensor_filter/tensor_filter_pytorch.cc:348:5: note: in expansion of macro ‘ml_loge’ ml_loge ("Invalid output meta: different element size at index %d. Found size %ld while expecting size %ld. Update the tensor shape/size to resolve the error.", ^~~~~~~ ``` Related with nnstreamer#3698 Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #3699. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnstreamer.mooo.com/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@myungjoo, 💯 All CI checkers are successfully verified. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There are different definitions for gsize. Use %G_GSIZE_FORMAT for the portability Note that nnstreamer#3699 was not portable enough. Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
There are different definitions for gsize. Use %G_GSIZE_FORMAT for the portability Note that nnstreamer#3699 was not portable enough. Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
There are different definitions for gsize. Use %G_GSIZE_FORMAT for the portability Note that #3699 was not portable enough. Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
Fix the print format string error:
Related with #3698
Signed-off-by: MyungJoo Ham myungjoo.ham@samsung.com