Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filter:pytorch: use %G_GSIZE_FORMAT for printing gsize #3701

Merged
merged 1 commit into from
Mar 30, 2022
Merged

filter:pytorch: use %G_GSIZE_FORMAT for printing gsize #3701

merged 1 commit into from
Mar 30, 2022

Conversation

myungjoo
Copy link
Member

There are different definitions for gsize.
Use %G_GSIZE_FORMAT for the portability
Note that #3699 was not portable enough.

Signed-off-by: MyungJoo Ham myungjoo.ham@samsung.com

@taos-ci
Copy link
Collaborator

taos-ci commented Mar 29, 2022

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #3701. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnstreamer.mooo.com/.

@taos-ci
Copy link
Collaborator

taos-ci commented Mar 29, 2022

:octocat: cibot: @myungjoo, apptest could not be completed. To find out the reasons, please go to http://nnstreamer.mooo.com//nnstreamer/ci/repo-workers/pr-checker/3701-202203291631390.39988088607788-9d9d48d7d7699fb49ea30f467b87563a9cf688d0

@taos-ci
Copy link
Collaborator

taos-ci commented Mar 29, 2022

:octocat: cibot: @myungjoo, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnstreamer.mooo.com/nnstreamer/ci/repo-workers/pr-checker/3701-202203291631390.39988088607788-9d9d48d7d7699fb49ea30f467b87563a9cf688d0/.

@myungjoo
filter:pytorch: use %G_GSIZE_FORMAT for printing gsize
9267039 
There are different definitions for gsize.
Use %G_GSIZE_FORMAT for the portability
Note that nnstreamer#3699 was not portable enough.

Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
taos-ci
taos-ci approved these changes Mar 29, 2022
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@myungjoo, 💯 All CI checkers are successfully verified. Thanks.

anyj0527
anyj0527 approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@anyj0527 anyj0527 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔

songgot
songgot approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@songgot songgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaeyun-jung jaeyun-jung merged commit 11ec30d into nnstreamer:main Mar 30, 2022
@myungjoo myungjoo deleted the gsize_format branch January 3, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anyj0527 anyj0527 anyj0527 approved these changes

@songgot songgot songgot approved these changes

@jaeyun-jung jaeyun-jung jaeyun-jung approved these changes

@taos-ci taos-ci taos-ci approved these changes

@jijoongmoon jijoongmoon Awaiting requested review from jijoongmoon jijoongmoon is a code owner

@again4you again4you Awaiting requested review from again4you again4you is a code owner

@leemgs leemgs Awaiting requested review from leemgs

@wooksong wooksong Awaiting requested review from wooksong wooksong is a code owner

@helloahn helloahn Awaiting requested review from helloahn

@kparichay kparichay Awaiting requested review from kparichay

@gichan-jang gichan-jang Awaiting requested review from gichan-jang gichan-jang is a code owner

@lhs8928 lhs8928 Awaiting requested review from lhs8928

@jihochu jihochu Awaiting requested review from jihochu jihochu is a code owner

@niley7464 niley7464 Awaiting requested review from niley7464 niley7464 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@myungjoo @taos-ci @anyj0527 @songgot @jaeyun-jung