Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[filter] Add SNPE filter supports API ver 2 #4382

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

anyj0527
Copy link
Member

Support SNPE2

  • Add a SNPE filter source tensor_filter_snpe.cc to support SNPE API version 2
    • It utilizes new C APIs.
  • Let meson decide cpp source file to compile by checking snpe_api_version

Fix unittest

  • Add dlc model files for SNPE2.
  • Rename SNPE1 model files.
  • Fix unittest to set proper model files.

Self evaluation:

  1. Build test: [x]Passed [ ]Failed [ ]Skipped
  2. Run test: [x]Passed [ ]Failed [ ]Skipped

@taos-ci
Copy link
Collaborator

taos-ci commented Jan 15, 2024

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #4382. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anyj0527, 💯 All CI checkers are successfully verified. Thanks.

- Add a SNPE filter source `tensor_filter_snpe.cc` to support SNPE API version 2
  - It utilizes new C APIs.
- Let meson decide cpp source file to compile by checking snpe_api_version

Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
- Add dlc model files for SNPE2.
- Rename SNPE1 model files.
- Fix unittest to set proper model files.

Signed-off-by: Yongjoo Ahn <yongjoo1.ahn@samsung.com>
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anyj0527, 💯 All CI checkers are successfully verified. Thanks.

GstTensorInfo *info
= gst_tensors_info_get_nth_info (std::addressof (inputInfo), i);
const char *inputName = Snpe_StringList_At (inputstrListHandle, i);
info->name = g_strdup (inputName);
Copy link
Collaborator

@jaeyun-jung jaeyun-jung Jan 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both input and output tensor, we can move this into handleTensor() :)

@myungjoo myungjoo merged commit 2181080 into nnstreamer:main Feb 1, 2024
35 of 37 checks passed
@anyj0527 anyj0527 deleted the support-snpe2 branch June 28, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants