Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MMF scrolling only works with one user profile [bug] #93

Closed
gaterose opened this issue May 3, 2021 · 7 comments
Closed

MMF scrolling only works with one user profile [bug] #93

gaterose opened this issue May 3, 2021 · 7 comments
Labels
Fast User Switching Issue Category

Comments

@gaterose
Copy link

gaterose commented May 3, 2021

Description

MMF scrolling will only work on one user profile. Tried with multiple input devices.

I originally installed MMF on my profile and have used it for almost a year. Found out over the weekend that the scroll wheel has never worked in my wife's user account so I deleted the app from her applications. I reinstalled MMF and it worked fine for her.

Today I logged back into my account and realized now scrolling doesn't work for me. Tried reinstalling MMF to no avail. Changing the side buttons from back/forward to spaces works fine but nothing will enable scrolling.

It may be worth mentioning that when MMF was a preference (instead of app) I would have to disable and re-enable MMF after every time she used the computer.

Steps to reproduce

Have multiple user accounts
Install MMF on one account

Context

Mac Mouse Fix Version: 2.0.0 Beta 5
macOS Version: 10.15.7
Mouse Model: logitech g502 (wired), Dell KM7321W (wireless), Logitech DiNovo Edge (wireless)

Additional Comments


Console Logs

Crash Reports

@noah-nuebling
Copy link
Owner

noah-nuebling commented May 3, 2021

Hey @gaterose, thank you for reaching out!

It's very valuable that you did, because I wasn't aware of this issue until now.

I've made some changes in 2.0.0 Beta 6 that should fix or at least improve things for you.
Let me know how that works for you guys.

@gaterose
Copy link
Author

gaterose commented May 4, 2021

Wow, thanks for the fast reply Noah! That seems to have fixed the scroll wheel, but now button 4 & 5 are left clicking instead of going back and forward as set in her profile. I tried some other functions, but it left-clicks no matter what. 4 & 5 seem to work right in my profile (the user account where I installed the app).

As mentioned above, in the previous version I was using (1.0.5 I think? whatever is on the website) 4 and 5 did work properly in both profiles even though scrolling didn't.

noah-nuebling added a commit that referenced this issue May 4, 2021
There are issues with fast user switching. See #93.

To fix these issues we changed all event taps to use the kCGSessionEventTap tapLocation.

But that introduces tons of new errors, because when we post events at the kCGSessionEventTap tapLocation (which we always do when we post events) they'll get re-picked up by the event taps at that location. This is really bad and could lead to tons of issues. It's a wonder that it works as decently as it does from my quick tests but I'm sure it introduces lots more subversive issues.

One of these issues is the one we fixed in this commit.
noah-nuebling added a commit that referenced this issue May 6, 2021
This change is aimed at the eventTaps of the current session taking precedence over the (Mac Mouse Fix) eventTaps of the switched out session in a fast user switching scenario.

That way you could hopefully re-enable Mac Mouse Fix when you switch to a new user session, and then have stuff work decently there.

This is obviously still a very suboptimal solution but it might help things for @gaterose and his wife (See #93) before we get around to properly refactor things so these issues won't occur anymore.

However this change is somewhat risky and might break things that weren't broken before if Mac Mouse Fix lives alongside other apps which tap into the eventStream, because Mac Mouse Fix will more aggressively take precedence over them.
@noah-nuebling
Copy link
Owner

Hey @gaterose, sorry for the late reply.

In the mean time there was a little meltdown where no one in the whole wide world could open the app anymore. But fortunately that's now tended to.

The quick fix to your problem I made in Beta 6 turned out to introduce many more issues than it alleviated.
I've thought about the underlying issue deeply and I discovered that I need to make big changes in the app to fix it properly without breaking a whole bunch of other stuff.
I've decided that it's not smart for me to implement these huge changes at this point in development. Sorry for that.

I have however made some changes in 2.0.0 Beta 9 that should make the app just as usable as the older 1.0 version you were using.
With Beta 9, after switching to a new account, simply turn Mac Mouse Fix off and on again to get things working.

If Mac Mouse Fix is running in one user session but not the other, scrolling will still not work in the user session which doesn't have Mac Mouse Fix running. To prevent these issues entirely, you could also log out before logging into a different user account.

Hope this helps, and if you have any more questions or issues you know the drill.

@MattKleinsmith
Copy link

MattKleinsmith commented Mar 11, 2023

Disabling and re-enabling Mac Mouse Fix has been my (inconvenient) workaround:

CleanShot 2023-03-10 at 20 35 33

Does anyone have an idea on how to automate this? I'm new to Mac. Maybe there's a user switch OS hook, where we could run a script that could kill Mac Mouse Fix and then start it again. Will post here if I figure it out.

Edit:

UserSwitchNotifications might be helpful.

@muzzakus
Copy link

muzzakus commented May 8, 2023

What a wonderful extension to the abysmal Apple support of 3rd party mice. However the lack of proper function for multiple accounts is a real bummer. Hope improvements can be made to an already stellar piece of software!

@noah-nuebling
Copy link
Owner

noah-nuebling commented Jan 15, 2024

Hey guys, I finally fixed this in the latest release 3.0.1!

Let me know if you have any more questions.

@noah-nuebling
Copy link
Owner

noah-nuebling commented Jan 15, 2024

Thanks @muzzakus for letting me know you like the app!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fast User Switching Issue Category
Projects
None yet
Development

No branches or pull requests

4 participants