Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google search #18

Closed
maliayas opened this issue Nov 5, 2013 · 1 comment
Closed

Google search #18

maliayas opened this issue Nov 5, 2013 · 1 comment

Comments

@maliayas
Copy link

maliayas commented Nov 5, 2013

It may not be a good idea. It causes you to give your private strings to google if it is unknown by the plugin.

I think web search is a standalone scope that must be left to another plugin and another keybinding.

I propose:

-               url = "http://google.com/#q=" + urllib.parse.quote(url, '')
-               webbrowser.open_new_tab(url)
+               print("open_url: URL/Path not understood")
@kylebebak
Copy link
Collaborator

@maliayas

Hey, web_searchers are now configurable in settings! The default web searcher, Google search, is just one of these web searchers. If you want get rid of it, add this to your Open URL settings:

"web_searchers": [],

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants