Added Docker Setup Option #1121
Conversation
kristinyim
requested review from
rohandas,
felixzhuologist,
noahpresler and
ecalder6
…dev txt, opened port 5432 in docker compose
|
@felixzhuologist could you take another look? I added this setup option to the Readthedocs as well |
build/semesterly-base/Dockerfile
Outdated
|
|
||
| ADD ./requirements_base.txt /tmp | ||
|
|
||
| RUN apt-get install -y \ |
There was a problem hiding this comment.
does this work? it looks like install and update are mixed up and i would expect to need to use && to run multiple commands. what would make the most sense to me would be to have a different run command/layer for each separate type of thing you're installing (debian package, node, python requirements):
RUN apt-get update -y && apt-get install ...
RUN curl .. && apt-get install -y nodejs
RUN pip install -r ...
There was a problem hiding this comment.
sorry, i didn't push the right version - its up now with &&
There was a problem hiding this comment.
last nit: can you separate the node and python commands into separate RUN instructions?
There was a problem hiding this comment.
I think I did what you wanted - you're talking about the last 3 lines right?
There was a problem hiding this comment.
yeah lgtm, thanks!
Instructions for setup is at docker-dev.txt
TODO: Add these instructions to readthedocs