-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: PC-13045 Good total single query experimental support #458
Open
marcinlawnik
wants to merge
12
commits into
main
Choose a base branch
from
PC-13045-splunk-single-query
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcinlawnik
requested review from
nieomylnieja,
skrolikiewicz and
daniel-zelazny
as code owners
June 12, 2024 11:09
# Conflicts: # go.work.sum
marcinlawnik
requested review from
nikodemrafalski,
kuklyy,
dawidwisn and
mkaras-nobl9
June 12, 2024 11:13
mkaras-nobl9
approved these changes
Jun 26, 2024
nieomylnieja
requested changes
Jun 27, 2024
nieomylnieja
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Enabling support for gathering godd and total points using single query.
Currently for Splunk only.
Sample YAML:
Summary
Added new
goodTotal
field to count metrics specAdded validation for splunk query with new field names
n9time
,n9good
,n9total
Testing
No release notes, as this is in experimental stage.