chore: PC-13045 Update SDK version #145
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….0 (#146) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/go-playground/validator/v10](https://togithub.com/go-playground/validator) | `v10.21.0` -> `v10.22.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>go-playground/validator (github.com/go-playground/validator/v10)</summary> ### [`v10.22.0`](https://togithub.com/go-playground/validator/releases/tag/v10.22.0): Release 10.22.0 [Compare Source](https://togithub.com/go-playground/validator/compare/v10.21.0...v10.22.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 10pm every weekday,before 5am every weekday,every weekend" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/nobl9/sloctl). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zOTMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM5My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJnb2xhbmciLCJyZW5vdmF0ZSJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/spf13/cobra](https://togithub.com/spf13/cobra) | `v1.8.0` -> `v1.8.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>spf13/cobra (github.com/spf13/cobra)</summary> ### [`v1.8.1`](https://togithub.com/spf13/cobra/releases/tag/v1.8.1) [Compare Source](https://togithub.com/spf13/cobra/compare/v1.8.0...v1.8.1) #### ✨ Features - Add env variable to suppress completion descriptions on create by [@​scop](https://togithub.com/scop) in [https://github.com/spf13/cobra/pull/1938](https://togithub.com/spf13/cobra/pull/1938) #### 🐛 Bug fixes - Micro-optimizations by [@​scop](https://togithub.com/scop) in [https://github.com/spf13/cobra/pull/1957](https://togithub.com/spf13/cobra/pull/1957) #### 🔧 Maintenance - build(deps): bump github.com/cpuguy83/go-md2man/v2 from 2.0.3 to 2.0.4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/spf13/cobra/pull/2127](https://togithub.com/spf13/cobra/pull/2127) - Consistent annotation names by [@​nirs](https://togithub.com/nirs) in [https://github.com/spf13/cobra/pull/2140](https://togithub.com/spf13/cobra/pull/2140) - Remove fully inactivated linters by [@​nirs](https://togithub.com/nirs) in [https://github.com/spf13/cobra/pull/2148](https://togithub.com/spf13/cobra/pull/2148) - Address golangci-lint deprecation warnings, enable some more linters by [@​scop](https://togithub.com/scop) in [https://github.com/spf13/cobra/pull/2152](https://togithub.com/spf13/cobra/pull/2152) #### 🧪 Testing & CI/CD - Add test for func in cobra.go by [@​korovindenis](https://togithub.com/korovindenis) in [https://github.com/spf13/cobra/pull/2094](https://togithub.com/spf13/cobra/pull/2094) - ci: test golang 1.22 by [@​cyrilico](https://togithub.com/cyrilico) in [https://github.com/spf13/cobra/pull/2113](https://togithub.com/spf13/cobra/pull/2113) - Optimized and added more linting by [@​scop](https://togithub.com/scop) in [https://github.com/spf13/cobra/pull/2099](https://togithub.com/spf13/cobra/pull/2099) - build(deps): bump actions/setup-go from 4 to 5 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/spf13/cobra/pull/2087](https://togithub.com/spf13/cobra/pull/2087) - build(deps): bump actions/labeler from 4 to 5 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/spf13/cobra/pull/2086](https://togithub.com/spf13/cobra/pull/2086) - build(deps): bump golangci/golangci-lint-action from 3.7.0 to 4.0.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/spf13/cobra/pull/2108](https://togithub.com/spf13/cobra/pull/2108) - build(deps): bump actions/cache from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/spf13/cobra/pull/2102](https://togithub.com/spf13/cobra/pull/2102) #### ✏️ Documentation - Fixes and docs for usage as plugin by [@​nirs](https://togithub.com/nirs) in [https://github.com/spf13/cobra/pull/2070](https://togithub.com/spf13/cobra/pull/2070) - flags: clarify documentation that LocalFlags related function do not modify the state by [@​niamster](https://togithub.com/niamster) in [https://github.com/spf13/cobra/pull/2064](https://togithub.com/spf13/cobra/pull/2064) - chore: remove repetitive words by [@​racerole](https://togithub.com/racerole) in [https://github.com/spf13/cobra/pull/2122](https://togithub.com/spf13/cobra/pull/2122) - Add LXC to the list of projects using Cobra [@​VaradBelwalkar](https://togithub.com/VaradBelwalkar) in [https://github.com/spf13/cobra/pull/2071](https://togithub.com/spf13/cobra/pull/2071) - Update projects_using_cobra.md by [@​marcuskohlberg](https://togithub.com/marcuskohlberg) in [https://github.com/spf13/cobra/pull/2089](https://togithub.com/spf13/cobra/pull/2089) - \[chore]: update projects using cobra by [@​cmwylie19](https://togithub.com/cmwylie19) in [https://github.com/spf13/cobra/pull/2093](https://togithub.com/spf13/cobra/pull/2093) - Add Taikun CLI to list of projects by [@​Smidra](https://togithub.com/Smidra) in [https://github.com/spf13/cobra/pull/2098](https://togithub.com/spf13/cobra/pull/2098) - Add Incus to the list of projects using Cobra by [@​montag451](https://togithub.com/montag451) in [https://github.com/spf13/cobra/pull/2118](https://togithub.com/spf13/cobra/pull/2118) #### New Contributors - [@​VaradBelwalkar](https://togithub.com/VaradBelwalkar) made their first contribution in [https://github.com/spf13/cobra/pull/2071](https://togithub.com/spf13/cobra/pull/2071) - [@​marcuskohlberg](https://togithub.com/marcuskohlberg) made their first contribution in [https://github.com/spf13/cobra/pull/2089](https://togithub.com/spf13/cobra/pull/2089) - [@​cmwylie19](https://togithub.com/cmwylie19) made their first contribution in [https://github.com/spf13/cobra/pull/2093](https://togithub.com/spf13/cobra/pull/2093) - [@​korovindenis](https://togithub.com/korovindenis) made their first contribution in [https://github.com/spf13/cobra/pull/2094](https://togithub.com/spf13/cobra/pull/2094) - [@​niamster](https://togithub.com/niamster) made their first contribution in [https://github.com/spf13/cobra/pull/2064](https://togithub.com/spf13/cobra/pull/2064) - [@​Smidra](https://togithub.com/Smidra) made their first contribution in [https://github.com/spf13/cobra/pull/2098](https://togithub.com/spf13/cobra/pull/2098) - [@​montag451](https://togithub.com/montag451) made their first contribution in [https://github.com/spf13/cobra/pull/2118](https://togithub.com/spf13/cobra/pull/2118) - [@​cyrilico](https://togithub.com/cyrilico) made their first contribution in [https://github.com/spf13/cobra/pull/2113](https://togithub.com/spf13/cobra/pull/2113) - [@​racerole](https://togithub.com/racerole) made their first contribution in [https://github.com/spf13/cobra/pull/2122](https://togithub.com/spf13/cobra/pull/2122) - [@​pedromotita](https://togithub.com/pedromotita) made their first contribution in [https://github.com/spf13/cobra/pull/2120](https://togithub.com/spf13/cobra/pull/2120) - [@​cubxxw](https://togithub.com/cubxxw) made their first contribution in [https://github.com/spf13/cobra/pull/2128](https://togithub.com/spf13/cobra/pull/2128) *** Thank you everyone who contributed to this release and all your hard work! Cobra and this community would never be possible without all of you!!!! 🐍 **Full Changelog**: spf13/cobra@v1.8.0...v1.8.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 10pm every weekday,before 5am every weekday,every weekend" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/nobl9/sloctl). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zOTMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM5My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJnb2xhbmciLCJyZW5vdmF0ZSJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [cspell](https://streetsidesoftware.github.io/cspell/) ([source](https://togithub.com/streetsidesoftware/cspell/tree/HEAD/packages/cspell)) | [`8.8.4` -> `8.9.0`](https://renovatebot.com/diffs/npm/cspell/8.8.4/8.9.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>streetsidesoftware/cspell (cspell)</summary> ### [`v8.9.0`](https://togithub.com/streetsidesoftware/cspell/blob/HEAD/packages/cspell/CHANGELOG.md#890-2024-06-18) [Compare Source](https://togithub.com/streetsidesoftware/cspell/compare/v8.8.4...v8.9.0) **Note:** Version bump only for package cspell </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 10pm every weekday,before 5am every weekday,every weekend" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/nobl9/sloctl). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTAuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQxMC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJqYXZhc2NyaXB0IiwicmVub3ZhdGUiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [cspell](https://streetsidesoftware.github.io/cspell/) ([source](https://togithub.com/streetsidesoftware/cspell/tree/HEAD/packages/cspell)) | [`8.9.0` -> `8.9.1`](https://renovatebot.com/diffs/npm/cspell/8.9.0/8.9.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>streetsidesoftware/cspell (cspell)</summary> ### [`v8.9.1`](https://togithub.com/streetsidesoftware/cspell/blob/HEAD/packages/cspell/CHANGELOG.md#small891-2024-06-20-small) [Compare Source](https://togithub.com/streetsidesoftware/cspell/compare/v8.9.0...v8.9.1) - docs: format tables in generated docs ([#​5776](https://togithub.com/streetsidesoftware/cspell/issues/5776)) ([02e0359](https://togithub.com/streetsidesoftware/cspell/commit/02e0359)), closes [#​5776](https://togithub.com/streetsidesoftware/cspell/issues/5776) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 10pm every weekday,before 5am every weekday,every weekend" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/nobl9/sloctl). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjQxMy4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJqYXZhc2NyaXB0IiwicmVub3ZhdGUiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
## Motivation Currently we're not really testing the `Dockerfile` image directly nor the built images. In our `bats` tests we're just using the Dockerfile to build the sloctl binary and copy it to bats container. Since running dind (Docker in Docker) images has proven tricky to me I've decided to write this basic tests in Go instead. The tests should only check basic interactions and not cover the larger spectrum that `bats` tests cover. ## Summary Updated workflows for e2e tests as well as release workflow. ## Testing Run: ```shell SLOCTL_CLIENT_ID=<ID> SLOCTL_CLIENT_SECRET=*** SLOCTL_OKTA_ORG_URL=<ORG_URL> SLOCTL_OKTA_AUTH_SERVER=<SERVER> SLOCTL_E2E_DOCKER_TEST_IMAGE=nobl9/sloctl make test/go/e2e ``` Note that `SLOCTL_E2E_DOCKER_TEST_IMAGE` is optional, if not provided the image will be built withing the test code. Example dispatch runs: - https://github.com/nobl9/sloctl/actions/runs/9697641809 - https://github.com/nobl9/sloctl/actions/runs/9697743409
## Related changes - nobl9/nobl9-go#471 ## Release Notes Fixed incorrect handling of double quoted JSON literals which caused errors when unmarshaling CloudWatch v1alpha SLOs with certain `json` queries.
## Motivation We're using `github.ref_name` which is the literal tag name, when passed as the image tag it results in: ``` Unable to find image 'nobl9/sloctl:v0.3.2' locally ``` We need to trim this `v` prefix in order for it to work. Since there's no easy way to do that in the workflow itself (because we're using reusable workflow), we need to trim it in the test code.
…to PC-13045-splunk-single-query # Conflicts: # go.mod # go.sum
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
DO NOT MERGE UNTIL SDK IS RELEASED
Sloctl using new SDK for testing.
Summary
Updated SDK
Related changes
List related changes from other PRs (if any).
Testing