Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use official CoreBluetooth API #828

Open
geovie opened this issue Sep 18, 2018 · 6 comments · May be fixed by #840
Open

Use official CoreBluetooth API #828

geovie opened this issue Sep 18, 2018 · 6 comments · May be fixed by #840

Comments

@geovie
Copy link

geovie commented Sep 18, 2018

Hi,
I rewrote the mac bindings to use native modules and the official CoreBluetooth API.

https://github.com/Timeular/noble-mac

The bindings provide the same functionality as the current mac bindings in this repository.

Are the noble developer interested in merging this in? The main benefit would be that the XPC protocol does not have to be reverse engineered every new MacOS release #727 #804

Kudos to Timeular for sponsoring my work on this.
@geovie geovie mentioned this issue Sep 18, 2018
Closed
@drandreas
Copy link

Thank you for your effort!

I've tried to verify your implementation against macOS Mojave. But currently all my node-gyp builds fail. I assume the root cause is the disabled support for 32bit builds in Mojave's SDK.

I will investigate further.

@readeral
Copy link

Hopefully this can be tightened up and merged! Will go a long way to solving some other open issues.

@drandreas
Copy link

Mojave is now public. Did any one else succeed in getting it to work?

@geovie
Copy link
Author

geovie commented Sep 28, 2018

@drandreas Can you try it again with the latest master? I've added node-pre-gyp so it should work for you

@drandreas
Copy link

drandreas commented Oct 1, 2018 •
edited

It works perfectly.

@notjosh notjosh mentioned this issue Oct 2, 2018
Open
@geovie geovie linked a pull request Nov 9, 2018 that will close this issue
Open
@geovie
Copy link
Author

geovie commented Nov 9, 2018

FYI I opened PR #840 which integrates the changes from noble-mac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Native mac bindings Timeular/noble
3 participants
@drandreas @readeral @geovie