Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] Bump webpack-dev-server from 3.1.3 to 3.1.14 #143

Merged

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Feb 17, 2019

Bumps webpack-dev-server from 3.1.3 to 3.1.14. This update includes security fixes.

Vulnerabilities fixed

Sourced from The npm Advisory Database.

Missing Origin Validation
Versions of webpack-dev-server before 3.1.10 are missing origin validation on the websocket server. This vulnerability allows a remote attacker to steal a developer's source code because the origin of requests to the websocket server that is used for Hot Module Replacement (HMR) are not validated.

Affected versions: <=3.1.10

Sourced from The Node Security Working Group.

Improper Input Validation
An issue was discovered in lib/Server.js in webpack-dev-server before 3.1.6. Attackers are able to steal developer's code because the origin of requests is not checked by the WebSocket server, which is used for HMR (Hot Module Replacement). Anyone can receive the HMR message sent by the WebSocket server via a ws://127.0.0.1:8080/ connection from any origin.

Affected versions: <=3.1.10

Release notes

Sourced from webpack-dev-server's releases.

v3.1.14

3.1.14 (2018-12-24)

Bug Fixes

  • add workaround for Origin header in sockjs (#1608) (1dfd4fb)

v3.1.13

3.1.13 (2018-12-22)

Bug Fixes

v3.1.12

3.1.12 (2018-12-22)

Bug Fixes

  • regression in checkHost for checking Origin header (#1606) (8bb3ca8)

v3.1.11

3.1.11 (2018-12-21)

Bug Fixes

v3.1.10

2018-10-23

Bug Fixes

  • options: add writeToDisk option to schema (#1520) (d2f4902)
  • package: update sockjs-client v1.1.5...1.3.0 (url-parse vulnerability) (#1537) (e719959)
  • Server: set tls.DEFAULT_ECDH_CURVE to 'auto' (#1531) (c12def3)
... (truncated)
Changelog

Sourced from webpack-dev-server's changelog.

3.1.14 (2018-12-24)

Bug Fixes

  • add workaround for Origin header in sockjs (#1608) (1dfd4fb)

3.1.13 (2018-12-22)

Bug Fixes

3.1.12 (2018-12-22)

Bug Fixes

  • regression in checkHost for checking Origin header (#1606) (8bb3ca8)

3.1.11 (2018-12-21)

Bug Fixes

3.1.10 (2018-10-23)

Bug Fixes

... (truncated)
Commits
Maintainer changes

This version was pushed to npm by evilebottnawi, a new releaser for webpack-dev-server since your current version.


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @thomaseizinger.


Note: This repo was added to Dependabot recently, so you'll receive a maximum of 3 PRs for your first few update runs. Once an update run creates fewer than 3 PRs we'll remove that limit.

You can always request more updates by clicking Bump now in your Dependabot dashboard.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

@dependabot-preview dependabot-preview bot added dependencies Pull requests that update a dependency file security Pull requests that address a security vulnerability labels Feb 17, 2019
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/webpack-dev-server-3.1.14 branch 3 times, most recently from ebdded9 to 254d277 Compare February 17, 2019 06:03
@thomaseizinger
Copy link
Member

Manual testing did not uncover any problems.

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/webpack-dev-server-3.1.14 branch from 254d277 to b66be23 Compare February 17, 2019 06:14
@thomaseizinger
Copy link
Member

@dependabot-bot merge

@dependabot-preview
Copy link
Contributor Author

Dependabot tried to merge this PR, but received the following error from GitHub:

At least 1 approving review is required by reviewers with write access.

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/webpack-dev-server-3.1.14 branch 5 times, most recently from 1503819 to 50d2126 Compare February 17, 2019 07:01
Bumps [webpack-dev-server](https://github.com/webpack/webpack-dev-server) from 3.1.3 to 3.1.14. **This update includes security fixes.**
- [Release notes](https://github.com/webpack/webpack-dev-server/releases)
- [Changelog](https://github.com/webpack/webpack-dev-server/blob/master/CHANGELOG.md)
- [Commits](webpack/webpack-dev-server@v3.1.3...v3.1.14)

Signed-off-by: dependabot[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/webpack-dev-server-3.1.14 branch from 50d2126 to e146b4e Compare February 17, 2019 07:10
@dependabot-preview dependabot-preview bot merged commit bb10115 into master Feb 17, 2019
@dependabot-preview dependabot-preview bot deleted the dependabot/npm_and_yarn/webpack-dev-server-3.1.14 branch February 17, 2019 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file security Pull requests that address a security vulnerability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants