-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
テストを追加 #4
テストを追加 #4
Conversation
chihiro-adachi
commented
Jun 7, 2019
- テストを追加
- オプションの有効無効を確認するように修正
$ProductClass->setDeliveryFee($delivery_fee); | ||
} else { | ||
$message = trans('admin.common.csv_invalid_greater_than_zero', | ||
['%line%' => $line, '%name%' => $headerByKey['delivery_fee']]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[PHP_CodeSniffer] Closing parenthesis of a multi-line function call must be on a line by itself (link)
posted by Sider
$ProductClass->setDeliveryFee($delivery_fee); | ||
} else { | ||
$message = trans('admin.common.csv_invalid_greater_than_zero', | ||
['%line%' => $line, '%name%' => $headerByKey['delivery_fee']]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[PHP_CodeSniffer] Multi-line function call not indented correctly; expected 20 spaces but found 24 (link)
posted by Sider
$message = trans('admin.common.csv_invalid_greater_than_zero', ['%line%' => $line, '%name%' => $headerByKey['delivery_fee']]); | ||
$this->addErrors($message); | ||
if ($this->BaseInfo->isOptionProductDeliveryFee()) { | ||
if (isset($row[$headerByKey['delivery_fee']]) && StringUtil::isNotBlank($row[$headerByKey['delivery_fee']])) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[PHP_CodeSniffer] Line exceeds 120 characters; contains 122 characters (link)
posted by Sider
if ($errors->count() === 0) { | ||
$ProductClass->setDeliveryFee($delivery_fee); | ||
} else { | ||
$message = trans('admin.common.csv_invalid_greater_than_zero', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[PHP_CodeSniffer] Opening parenthesis of a multi-line function call must be the last content on the line (link)
posted by Sider