テストを追加 #4
Merged
テストを追加 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chihiro-adachi
commented
Jun 7, 2019
chihiro-adachi
commented
- テストを追加
- オプションの有効無効を確認するように修正
11 tasks
nobuhiko
reviewed
Jun 7, 2019
| $ProductClass->setDeliveryFee($delivery_fee); | ||
| } else { | ||
| $message = trans('admin.common.csv_invalid_greater_than_zero', | ||
| ['%line%' => $line, '%name%' => $headerByKey['delivery_fee']]); |
There was a problem hiding this comment.
[PHP_CodeSniffer] Closing parenthesis of a multi-line function call must be on a line by itself (link)
posted by Sider
nobuhiko
reviewed
Jun 7, 2019
| $ProductClass->setDeliveryFee($delivery_fee); | ||
| } else { | ||
| $message = trans('admin.common.csv_invalid_greater_than_zero', | ||
| ['%line%' => $line, '%name%' => $headerByKey['delivery_fee']]); |
There was a problem hiding this comment.
[PHP_CodeSniffer] Multi-line function call not indented correctly; expected 20 spaces but found 24 (link)
posted by Sider
nobuhiko
reviewed
Jun 7, 2019
| $message = trans('admin.common.csv_invalid_greater_than_zero', ['%line%' => $line, '%name%' => $headerByKey['delivery_fee']]); | ||
| $this->addErrors($message); | ||
| if ($this->BaseInfo->isOptionProductDeliveryFee()) { | ||
| if (isset($row[$headerByKey['delivery_fee']]) && StringUtil::isNotBlank($row[$headerByKey['delivery_fee']])) { |
There was a problem hiding this comment.
[PHP_CodeSniffer] Line exceeds 120 characters; contains 122 characters (link)
posted by Sider
nobuhiko
reviewed
Jun 7, 2019
| if ($errors->count() === 0) { | ||
| $ProductClass->setDeliveryFee($delivery_fee); | ||
| } else { | ||
| $message = trans('admin.common.csv_invalid_greater_than_zero', |
There was a problem hiding this comment.
[PHP_CodeSniffer] Opening parenthesis of a multi-line function call must be the last content on the line (link)
posted by Sider
nobuhiko
pushed a commit
that referenced
this pull request
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.