Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Can I write an async request body matcher? #1060

Closed
stroiman opened this issue Feb 7, 2018 · 7 comments
Closed

Question: Can I write an async request body matcher? #1060

stroiman opened this issue Feb 7, 2018 · 7 comments
Labels

Comments

@stroiman
Copy link

stroiman commented Feb 7, 2018

The post function allows me to create a predicate, if a specific request should be matched or not. In my case, I need to differentiate on xml data in the post, and my xml parser is async.

Is there a way I can write an async predicate for the post body?

As a workaround, I have created a regex matcher, that just matches the small part of the xml containing the interesting ids.

@gr2m
Copy link
Member

gr2m commented Feb 7, 2018

I don’t know myself, but sounds like something that should be supported

@stroiman stroiman changed the title Question: Can I write an async request body Question: Can I write an async request body matcher? Feb 8, 2018
@stale
Copy link

stale bot commented Sep 14, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We try to do our best, but nock is maintained by volunteers and there is only so much we can do at a time. Thank you for your contributions.

@stale stale bot added the stale label Sep 14, 2018
@stale stale bot closed this as completed Sep 21, 2018
@giodamelio
Copy link

This would be a really nice thing to have. I am running into an issue right now, where I want to parse some multipart form data in the request body parser and I can't since the form data parser is streaming.

@gr2m
Copy link
Member

gr2m commented Oct 2, 2018

@giodamelio if you like, open a new issue for it? But you’d need to champion it to get it shipped, we can only facilitate your contribution and make it as pleasant an experience as possible. We can’t do it ourselves I’m afraid

@giodamelio
Copy link

giodamelio commented Oct 3, 2018 via email

@lock
Copy link

lock bot commented Oct 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you!

@lock lock bot locked as resolved and limited conversation to collaborators Oct 17, 2018
@gr2m
Copy link
Member

gr2m commented Oct 17, 2018

@giodamelio please open a new issue if you find time to work on it, no rush :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants