Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests don't skip using --only when there is a hashmark in the test name #1271

Closed
RichardLitt opened this issue Dec 14, 2018 · 5 comments
Closed

Comments

@RichardLitt
Copy link
Member

What is the expected behavior?

Tests should skip if you're running tap --only test/*.js.

What is the actual behavior?

They don't if there is a # in the test description.

Possible solution

Just move all of the (#921) like comments from the test descriptions.

How to reproduce the issue

Run AIRPLANE=true tap --only ./tests/test_intercept.js -Rspec.

@paulmelnikow
Copy link
Member

Tap docs on skipping failing tests: https://www.node-tap.org/cli/

paulmelnikow added a commit that referenced this issue Dec 14, 2018
paulmelnikow added a commit that referenced this issue Dec 14, 2018
RichardLitt added a commit that referenced this issue Dec 14, 2018
RichardLitt pushed a commit that referenced this issue Dec 14, 2018
@nockbot
Copy link
Collaborator

nockbot commented Dec 18, 2018

🎉 This issue has been resolved in version 11.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nockbot
Copy link
Collaborator

nockbot commented Dec 23, 2018

🎉 This issue has been resolved in version 10.0.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lock
Copy link

lock bot commented Jan 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you!

@lock lock bot locked as resolved and limited conversation to collaborators Jan 6, 2019
@nockbot
Copy link
Collaborator

nockbot commented Aug 13, 2019

🎉 This issue has been resolved in version 11.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants