Tests should send mocked requests to fake hostname

[paulmelnikow]

Let's change them all from e.g. example.com and www.google.com to example.test.

See #1347 (comment)

[jlilja]

Mind if I take this? Seeing as its marked as a first time issue, should I let someone else take it? :)

[paulmelnikow]

Go for it!!

I try to be really generous with tagging good first issues. There's a ton of work that can be done on this project and I don't think we need to worry about not creating enough of it. 😁

[gr2m]

Thanks @paulmelnikow, this great!

[jlilja]

Alright. I think I got most of these done. Some of the tests make assertions based on actually getting through - like enable net connect and allowUnmocked options.

How about setting google.com for those requests that actually have to go through, and a.google.com for subdomain checks?

[paulmelnikow]

Ah, I came across one like that before as well. If the tests are still based on getting through, they need to be rewritten. Basically, they should have used AIRPLANE but didn't. You could add TODOs, I think…

[jlilja]

Oh right. Yeah I'll add TODOs and make an PR out of it.

[gr2m]

Maybe instead of using google.com, we could spawn our own servers and mock localhost?

[paulmelnikow]

@jlilja How are you coming with this? It'd be great to get these updated so new contributors add tests in the style we want. Even if it's only partly done we could merge it.

[jlilja]

Hi, yes of course. I'm working on it right now.

I'll push the changing of names soon, then another PR for converting the other ones needing its own server.

[ehabdevel]

I may came late to this but,
wasn't it be more clear if using a domain like this:-> http://www.someSite.url
which also doesn’t send requests to a real domain.

[gr2m]

I think .test is made for exactly this use case, see https://en.wikipedia.org/wiki/.test

The name test is a top-level domain (TLD) that is intended for use in the testing of software.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We try to do our best, but nock is maintained by volunteers and there is only so much we can do at a time. Thank you for your contributions.

[mastermatt]

I think this is done. @paulmelnikow do you want to give the tests one last check before closing this issue?

[paulmelnikow]

These are the ones I'm still seeing:

• There are a couple instances of www.google.com in test_recorder. (fixed in refactor: Fix two tests that don't work on an airplane #1679)
• There are google.com and amazon.com in test_back and a google.com in fixtures/goodRequest.json. (refactor: Remove the last of the real hostnames #1691 and refactor: Update hostname in goodRequest.json #1689)
• There are google.com and amazon.com in test_net_connect. (refactor: Refactor net connect tests #1688)
• test_s3 should be removed / refactored, though I guess we could consider that to be unrelated to this issue. (test: Replace test_s3 with test of Expect: 100-continue #1690)

I'm not sure if any of these involve sending requests, though I think it's better we replace these with .test domains if possible.

[paulmelnikow]

I've opened PRs for the rest of these.