Help wanted to reach 100% coverage in lib/recorder.js #1607
Labels
Comments
paulmelnikow
added a commit
that referenced
this issue
Jul 8, 2019
paulmelnikow
added a commit
that referenced
this issue
Jul 8, 2019
Ref #1404 (comment) This leaves intact two missed coverage spots in `lib/recorder.js` which are being taken care of in #1588. Also ref #1607
|
I'm taking a look at this now. |
|
🎉 This issue has been resolved in version 11.0.0-beta.24 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This issue has been resolved in version 11.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
gr2m
pushed a commit
that referenced
this issue
Sep 4, 2019
Ref #1404 (comment) This leaves intact two missed coverage spots in `lib/recorder.js` which are being taken care of in #1588. Also ref #1607
gr2m
pushed a commit
that referenced
this issue
Sep 4, 2019
Ref #1404 (comment) This leaves intact two missed coverage spots in `lib/recorder.js` which are being taken care of in #1588. Also ref #1607
gr2m
pushed a commit
that referenced
this issue
Sep 5, 2019
Ref #1404 (comment) This leaves intact two missed coverage spots in `lib/recorder.js` which are being taken care of in #1588. Also ref #1607
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As a continuation of #1404, note that there are several
TODO-coveragecomments inlib/recorder.jswhich are paired with istanbul ignores.We'd like to clean these up. With 100% test coverage, the tests take on a life of their own in maintaining the project, and will allow us to refactor – and add functionality – with confidence.
Anyone is welcome to pick up this work! Feel free to post here first to avoid duplicating work 😀
One bit of guidance (copied from #1404): our test strategy is to avoid narrow-bracket tests, and instead aim to keep writing high-level functional tests (i.e. via calls to
nock()). If there is not a way to exercise the code through the publicnockAPI, it may be dead code. In the case of dead code, it's better to remove it than to add tests.The text was updated successfully, but these errors were encountered: