replyWithError doesn't work with got

[tkalinowskiIress]

What is the expected behavior?

replyWithError('err') or reply(500, {error: 'err'}) should return give valid error response in catch block when doing a request with got

What is the actual behavior?

Nock is crashing

Possible solution

How to reproduce the issue

Glitch: Example link
Codesandbox: Example link

Does the bug have a test case?

Versions

Latest stable and beta. I for some reason latest beta has some problem with dependencies on both Glitch and CodeSandbox, so i've used 11.0.0-beta.29 but it reproduces locally

Software	Version(s)
Nock	11.0.0-beta.29
got	9.6.0
Node

[paulmelnikow]

Ahhh, see #1523.

Got issues retries by default. This makes for confusing testing, and I think perhaps not a great default.

Try:

const response = await got("http://test/", { retry: 0 });

Or see our solution:

nock/tests/got_client.js

Lines 3 to 6 in 11dba99

	const got = require('got')
	// https://github.com/nock/nock/issues/1523
	module.exports = got.extend({ retry: 0 })

I expect other devs to run into this issue so I'd welcome a pull request with a documentation update!

[nockbot]

🎉 This issue has been resolved in version 11.3.2 🎉

The release is available on:

• npm package (@next dist-tag)
• GitHub release

Your semantic-release bot 📦🚀