Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(test_request_promise): Remove a library-specific test #1525

Merged
merged 1 commit into from
May 2, 2019

Conversation

paulmelnikow
Copy link
Member

@paulmelnikow paulmelnikow commented May 1, 2019

This use cases seems to be covered by tests in test_ipv6.js.

Goes along with our decision in #1427 and prior, of handling nock-client integration tests in separate repos.

@paulmelnikow paulmelnikow changed the title test(test_request_promise): Remove library-specific tests test(test_request_promise): Remove a library-specific test May 1, 2019
This use cases seems to be covered by tests in `test_ipv6.js`.

Goes along with our decision in #1427 and prior, of handling nock-client integration tests in separate repos.
Copy link
Member

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@gr2m gr2m merged commit aabc003 into beta May 2, 2019
@nockbot
Copy link
Collaborator

nockbot commented May 2, 2019

🎉 This PR is included in version 11.0.0-beta.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

@paulmelnikow paulmelnikow deleted the rm-request-promise-tests branch May 2, 2019 03:48
@nockbot
Copy link
Collaborator

nockbot commented Aug 12, 2019

🎉 This PR is included in version 11.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants