bug(recorder): replace qs lib with native querystring

[mastermatt]

The qs dependency was removed, however, recorder.js retained usage of it.
Replacing it with querystring from the std lib is sufficient.

Introduced: #1632
Fixes: #1651

Note that the output of generateRequestAndResponse will change for requests with search params, however, the net effect when that output is used will be the same.

[paulmelnikow]

Wouldn't this break recordings created in the old version?

[mastermatt]

I don't think so, but I'll add a test using a recording from v10.

[mastermatt]

This change doesn't affect the way recordings are processed, just recorded when output_objects is not set to true.

example:

got('https://example.com/todos/1?foo[bar]=123&baz[0]=a&baz[1]=b')

// output before change
nock('https://example.com:443', {"encodedQueryParams":true})
  .get('/todos/1')
  .query({"foo":{"bar":"123"},"baz":["a","b"]})
  ...

// output after change
nock('https://example.com:443', {"encodedQueryParams":true})
  .get('/todos/1')
  .query({"foo%5Bbar%5D":"123","baz%5B0%5D":"a","baz%5B1%5D":"b"})
  ...

And we already have tests in test_complex_querystring.js showing that both styles are able to be processed.

[paulmelnikow]

Thanks for looking into that!

[nockbot]

🎉 This PR is included in version 11.0.0 🎉

The release is available on:

• npm package (@next dist-tag)
• GitHub release

Your semantic-release bot 📦🚀