Fixed response not resuming on drain #175
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #146 by marking
OutgoingMessage
(a writable stream) as readable allowing resuming of mocking by Node itself (deep in its streams library) when drained. This is a hack obviously but it works. I think that the proper way to actually solve this is to makeresponse
be aIncomingMessage
(as that's what we are mocking - incoming messages) but I got all sorts of errors when I started down that path so I let it be for now.