refactor(test): use Mocha DSL for allow unmocked #1894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
mastermatt
force-pushed
the
mocha-allow-unmocked
branch
from
a3da777
to
1ceddae
Compare
paulmelnikow
pushed a commit
that referenced
this pull request
Feb 11, 2020
* refactor(test): use Mocha DSL for allow unmocked
paulmelnikow
added a commit
that referenced
this pull request
Feb 11, 2020
paulmelnikow
added a commit
that referenced
this pull request
Feb 11, 2020
…1825) * chore(package): update got to version 10.0.0 * chore(package): update lockfile package-lock.json * Bump got again and run npm install * query -> searchParams * encoding -> responseType * `{body: …}` no longer implies `.post()` * auth -> username + password * query -> searchParams * Error now has a `response` property * Couple other fixes * Restore 100% coverage * Update lockfile * refactor(test): use Mocha DSL for allow unmocked (#1894) * refactor(test): use Mocha DSL for allow unmocked * Fix format * baseUrl -> prefixUrl * Update json’s for breaking changes * update usage of prefixUrl. There was a subtle, and I think unnecessary, change in Got 10.x where using `prefixUrl` means the input, when making a request, can no longer have a leading slash. The prefix value can optionally have a trailing slash. https://github.com/sindresorhus/got#prefixurl Co-authored-by: Paul Melnikow <github@paulmelnikow.com> Co-authored-by: Matt R. Wilson <github@mattw.co>
Closed
mastermatt
added a commit
to mastermatt/nock
that referenced
this pull request
Feb 12, 2020
…ock#1825) * chore(package): update got to version 10.0.0 * chore(package): update lockfile package-lock.json * Bump got again and run npm install * query -> searchParams * encoding -> responseType * `{body: …}` no longer implies `.post()` * auth -> username + password * query -> searchParams * Error now has a `response` property * Couple other fixes * Restore 100% coverage * Update lockfile * refactor(test): use Mocha DSL for allow unmocked (nock#1894) * refactor(test): use Mocha DSL for allow unmocked * Fix format * baseUrl -> prefixUrl * Update json’s for breaking changes * update usage of prefixUrl. There was a subtle, and I think unnecessary, change in Got 10.x where using `prefixUrl` means the input, when making a request, can no longer have a leading slash. The prefix value can optionally have a trailing slash. https://github.com/sindresorhus/got#prefixurl Co-authored-by: Paul Melnikow <github@paulmelnikow.com> Co-authored-by: Matt R. Wilson <github@mattw.co>
paulmelnikow
added a commit
that referenced
this pull request
Feb 13, 2020
…1825) * chore(package): update got to version 10.0.0 * chore(package): update lockfile package-lock.json * Bump got again and run npm install * query -> searchParams * encoding -> responseType * `{body: …}` no longer implies `.post()` * auth -> username + password * query -> searchParams * Error now has a `response` property * Couple other fixes * Restore 100% coverage * Update lockfile * refactor(test): use Mocha DSL for allow unmocked (#1894) * refactor(test): use Mocha DSL for allow unmocked * Fix format * baseUrl -> prefixUrl * Update json’s for breaking changes * update usage of prefixUrl. There was a subtle, and I think unnecessary, change in Got 10.x where using `prefixUrl` means the input, when making a request, can no longer have a leading slash. The prefix value can optionally have a trailing slash. https://github.com/sindresorhus/got#prefixurl Co-authored-by: Paul Melnikow <github@paulmelnikow.com> Co-authored-by: Matt R. Wilson <github@mattw.co>
|
🎉 This PR is included in version 11.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
gr2m
pushed a commit
that referenced
this pull request
Feb 16, 2020
…1825) * chore(package): update got to version 10.0.0 * chore(package): update lockfile package-lock.json * Bump got again and run npm install * query -> searchParams * encoding -> responseType * `{body: …}` no longer implies `.post()` * auth -> username + password * query -> searchParams * Error now has a `response` property * Couple other fixes * Restore 100% coverage * Update lockfile * refactor(test): use Mocha DSL for allow unmocked (#1894) * refactor(test): use Mocha DSL for allow unmocked * Fix format * baseUrl -> prefixUrl * Update json’s for breaking changes * update usage of prefixUrl. There was a subtle, and I think unnecessary, change in Got 10.x where using `prefixUrl` means the input, when making a request, can no longer have a leading slash. The prefix value can optionally have a trailing slash. https://github.com/sindresorhus/got#prefixurl Co-authored-by: Paul Melnikow <github@paulmelnikow.com> Co-authored-by: Matt R. Wilson <github@mattw.co>
gr2m
pushed a commit
that referenced
this pull request
Feb 16, 2020
…1825) * chore(package): update got to version 10.0.0 * chore(package): update lockfile package-lock.json * Bump got again and run npm install * query -> searchParams * encoding -> responseType * `{body: …}` no longer implies `.post()` * auth -> username + password * query -> searchParams * Error now has a `response` property * Couple other fixes * Restore 100% coverage * Update lockfile * refactor(test): use Mocha DSL for allow unmocked (#1894) * refactor(test): use Mocha DSL for allow unmocked * Fix format * baseUrl -> prefixUrl * Update json’s for breaking changes * update usage of prefixUrl. There was a subtle, and I think unnecessary, change in Got 10.x where using `prefixUrl` means the input, when making a request, can no longer have a leading slash. The prefix value can optionally have a trailing slash. https://github.com/sindresorhus/got#prefixurl Co-authored-by: Paul Melnikow <github@paulmelnikow.com> Co-authored-by: Matt R. Wilson <github@mattw.co>
gr2m
pushed a commit
that referenced
this pull request
Feb 16, 2020
…1825) * chore(package): update got to version 10.0.0 * chore(package): update lockfile package-lock.json * Bump got again and run npm install * query -> searchParams * encoding -> responseType * `{body: …}` no longer implies `.post()` * auth -> username + password * query -> searchParams * Error now has a `response` property * Couple other fixes * Restore 100% coverage * Update lockfile * refactor(test): use Mocha DSL for allow unmocked (#1894) * refactor(test): use Mocha DSL for allow unmocked * Fix format * baseUrl -> prefixUrl * Update json’s for breaking changes * update usage of prefixUrl. There was a subtle, and I think unnecessary, change in Got 10.x where using `prefixUrl` means the input, when making a request, can no longer have a leading slash. The prefix value can optionally have a trailing slash. https://github.com/sindresorhus/got#prefixurl Co-authored-by: Paul Melnikow <github@paulmelnikow.com> Co-authored-by: Matt R. Wilson <github@mattw.co>
gr2m
pushed a commit
that referenced
this pull request
Feb 16, 2020
…1825) * chore(package): update got to version 10.0.0 * chore(package): update lockfile package-lock.json * Bump got again and run npm install * query -> searchParams * encoding -> responseType * `{body: …}` no longer implies `.post()` * auth -> username + password * query -> searchParams * Error now has a `response` property * Couple other fixes * Restore 100% coverage * Update lockfile * refactor(test): use Mocha DSL for allow unmocked (#1894) * refactor(test): use Mocha DSL for allow unmocked * Fix format * baseUrl -> prefixUrl * Update json’s for breaking changes * update usage of prefixUrl. There was a subtle, and I think unnecessary, change in Got 10.x where using `prefixUrl` means the input, when making a request, can no longer have a leading slash. The prefix value can optionally have a trailing slash. https://github.com/sindresorhus/got#prefixurl Co-authored-by: Paul Melnikow <github@paulmelnikow.com> Co-authored-by: Matt R. Wilson <github@mattw.co>
gr2m
pushed a commit
that referenced
this pull request
Feb 16, 2020
…1825) * chore(package): update got to version 10.0.0 * chore(package): update lockfile package-lock.json * Bump got again and run npm install * query -> searchParams * encoding -> responseType * `{body: …}` no longer implies `.post()` * auth -> username + password * query -> searchParams * Error now has a `response` property * Couple other fixes * Restore 100% coverage * Update lockfile * refactor(test): use Mocha DSL for allow unmocked (#1894) * refactor(test): use Mocha DSL for allow unmocked * Fix format * baseUrl -> prefixUrl * Update json’s for breaking changes * update usage of prefixUrl. There was a subtle, and I think unnecessary, change in Got 10.x where using `prefixUrl` means the input, when making a request, can no longer have a leading slash. The prefix value can optionally have a trailing slash. https://github.com/sindresorhus/got#prefixurl Co-authored-by: Paul Melnikow <github@paulmelnikow.com> Co-authored-by: Matt R. Wilson <github@mattw.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For: #1305
Because of the indention changes, reviewing this PR without whitespace is much easier:
https://github.com/nock/nock/pull/1894/files?w=1