Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: numeric field display issue in form linkage rule #4482

Merged
merged 2 commits into from
May 25, 2024
Merged

fix: numeric field display issue in form linkage rule #4482

merged 2 commits into from
May 25, 2024

Conversation

katherinehhh
Copy link
Contributor

Description

Motivation

Key changes

  • Frontend
  • Backend

Test plan

Suggestions

Underlying risk

Showcase

Copy link

height bot commented May 25, 2024

This pull request has been linked to 1 task:

  • T-4356 表单联动规则赋值数字字段值为0.00显示[object Object] (unlink task)

💡Tip: Add "Close T-4356" to the pull request title or description, to a commit message, or in a comment to mark this task as "Done" when the pull request is merged.

This comment has been minimized.

Copy link

Tests results for "E2E"

15 flaky ⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/table/__e2e__/schemaSettings.test.ts:388:9 › actions schema settings › update record › Assign field values
⚠️ [chromium] › plugins/@nocobase/plugin-action-bulk-edit/src/client/__e2e__/schemaSettings.test.ts:14:7 › bulk edit action setting › data will be updated && edit form configure
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/grid-card/__e2e__/schemaInitializer.test.ts:30:7 › where grid card block can be added › popup
⚠️ [chromium] › core/client/src/modules/page/__e2e__/dragAndDrop.test.ts:12:5 › tabs
⚠️ [chromium] › plugins/@nocobase/plugin-gantt/src/client/__e2e__/schemaInitailizer.test.ts:13:5 › BlockInitializers should add gantt block
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/form/__e2e__/form-create/dragAndDrop.test.ts:12:5 › fields
⚠️ [chromium] › plugins/@nocobase/plugin-acl/src/client/__e2e__/configure.test.ts:13:5 › allows to configure interface
⚠️ [chromium] › plugins/@nocobase/plugin-action-print/src/client/__e2e__/schemaInitailizer.test.ts:14:7 › ReadPrettyFormActionInitializers & CalendarFormActionInitializers should add print action › print action in ReadPrettyFormActionInitializers
⚠️ [chromium] › plugins/@nocobase/plugin-auth/src/client/__e2e__/auth.test.ts:21:7 › auth › register
⚠️ [chromium] › plugins/@nocobase/plugin-file-manager/src/client/__e2e__/block.test.ts:53:7 › file collection block › correctly size
⚠️ [chromium] › plugins/@nocobase/plugin-workflow/src/client/__e2e__/conditionNode/continueWhenYesFormulaEngine.test.ts:30:5 › Collection event Add Data Trigger, Formula engine, determines that the trigger node single line text field variable is equal to an equal constant, passes.
⚠️ [chromium] › plugins/@nocobase/plugin-workflow/src/client/__e2e__/conditionNode/BranchIntoYesAndNoFormulaEngine.test.ts:146:5 › Collection event Add Data Trigger, determines that the trigger node single line text field variable is equal to an unequal constant, fails.
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/list/__e2e__/schemaInitializer.test.ts:29:7 › where list block can be added › popup
⚠️ [chromium] › plugins/@nocobase/plugin-acl/src/client/__e2e__/association.test.ts:245:5 › association block action permission
⚠️ [chromium] › plugins/@nocobase/plugin-action-bulk-edit/src/client/__e2e__/schemaInitailizer.test.ts:14:7 › TableActionInitializers & GanttActionInitializers & MapActionInitializers should add bulk edit action › bulk edit in TableActionInitializers

972 passed, 28 skipped
✔️✔️✔️

Full HTML report. Merge workflow run.

@hongboji hongboji merged commit 8a86322 into main May 25, 2024
8 checks passed
@hongboji hongboji deleted the T-4356 branch May 25, 2024 23:37
jessetalk added a commit to Ulprotron/nocobase that referenced this pull request May 28, 2024
* Yun002 (#2)

* feat(independent-page): set independent-page

* feat(plugin): add fuzhijia clock plugin

* feat(clock): complete fuzhijia clock

* fix(clock): map issue after refreshing page

* fix(clock): tmap clock issue

* feat(wxcom-auth): add wxcom auth plugin

* fix(merge): merge from main

---------

Co-authored-by: jessetalk <>

* Update README.md

* Update README.zh-CN.md

* Update README.zh-CN.md

* fix:  numeric field display issue in form linkage rule (nocobase#4482)

* fix:  numeric field display issue in form linkage rule

* fix: bug

* chore(versions): 😊 publish v1.0.0-alpha.16

* chore: update changelog

* Update README.md

* Update README.zh-CN.md

* Update README.md

* chore: database prepare error message

* chore: retry in dev env

* refactor: form linkage rule to cancel assignment when multiple fields are selected (nocobase#4492)

* fix: optimize data scope variable in permission configuration (nocobase#4484)

* fix: optimize data scope variable in permission configuration

* test: add e2e test

* chore: fix failed e2e

* fix: optimize data scope variable in permission configuration

* chore: skip weird test

* fix: auto change log

* chore(versions): 😊 publish v1.0.0-alpha.17

* chore: update changelog

* feat: update LICENSE

* fix: sub-table support allowAddNew setting (nocobase#4498)

* chore(auth): change char length limit of username to 1-50 (nocobase#4502)

* fix: fix loss of data scope field in permission configuration

* fix: after update event in single relation repository (nocobase#4503)

* fix: after update event in single relation repository

* test(plugin-workflow): add association collection trigger

---------

Co-authored-by: mytharcher <mytharcher@gmail.com>

* refactor: remove all frontend checks for isForeignKey (nocobase#4499)

* refactor: remove all frontend checks for isForeignKey

* fix: bug

---------

Co-authored-by: estheryo <32948748+estheryo@users.noreply.github.com>
Co-authored-by: Katherine <shunai.tang@hand-china.com>
Co-authored-by: GitHub Actions Bot <actions@github.com>
Co-authored-by: Chareice <chareice@live.com>
Co-authored-by: Zeke Zhang <958414905@qq.com>
Co-authored-by: zhou <zhou.working@gmail.com>
Co-authored-by: YANG QIA <2013xile@gmail.com>
Co-authored-by: mytharcher <mytharcher@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants