Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: optimize data scope variable in permission configuration #4484

Merged
merged 6 commits into from
May 27, 2024
Merged

fix: optimize data scope variable in permission configuration #4484

merged 6 commits into from
May 27, 2024

Conversation

zhangzhonghe
Copy link
Contributor

close T-4348

@height Height
Copy link

height bot commented May 26, 2024 •
edited

This pull request has been linked to and will mark 1 task as "Done" when merged:

  • T-4348 角色中数据源下数据表自定义范围权限，变量中多了当前表单、弹窗记录的变量，应该去掉 (unlink task)

💡Tip: You can link multiple Height tasks to a pull request.

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link

Tests results for "E2E"

15 flaky ⚠️ [chromium] › plugins/@nocobase/plugin-data-source-main/src/client/__e2e__/fields/belongsTo/schemaSettings2.test.ts:56:7 › form item & edit form › pattern
⚠️ [chromium] › plugins/@nocobase/plugin-workflow/src/client/__e2e__/ScheduleEventTrigger/workflowCRUD.test.ts:74:7 › Delete › delete Schedule event
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/table/__e2e__/schemaSettings1.test.ts:92:9 › table block schema settings › enable drag and drop sorting › enable drag and drop sorting
⚠️ [chromium] › plugins/@nocobase/plugin-acl/src/client/__e2e__/configure.test.ts:13:5 › allows to configure interface
⚠️ [chromium] › plugins/@nocobase/plugin-action-bulk-edit/src/client/__e2e__/schemaSettings.test.ts:14:7 › bulk edit action setting › data will be updated && edit form configure
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/table/__e2e__/schemaSettings.test.ts:388:9 › actions schema settings › update record › Assign field values
⚠️ [chromium] › plugins/@nocobase/plugin-action-print/src/client/__e2e__/schemaInitailizer.test.ts:14:7 › ReadPrettyFormActionInitializers & CalendarFormActionInitializers should add print action › print action in ReadPrettyFormActionInitializers
⚠️ [chromium] › plugins/@nocobase/plugin-auth/src/client/__e2e__/auth.test.ts:21:7 › auth › register
⚠️ [chromium] › plugins/@nocobase/plugin-gantt/src/client/__e2e__/drag.test.ts:13:5 › drag and adjust start time, end time, and progress
⚠️ [chromium] › plugins/@nocobase/plugin-workflow/src/client/__e2e__/conditionNode/continueWhenYesFormulaEngine.test.ts:30:5 › Collection event Add Data Trigger, Formula engine, determines that the trigger node single line text field variable is equal to an equal constant, passes.
⚠️ [chromium] › plugins/@nocobase/plugin-workflow/src/client/__e2e__/conditionNode/continueWhenYesFormulaEngine.test.ts:196:5 › Collection event Add Data Trigger, Formula engine, determines that the trigger node single line text field variable is not equal to an equal constant, fails.
⚠️ [chromium] › plugins/@nocobase/plugin-acl/src/client/__e2e__/association.test.ts:245:5 › association block action permission
⚠️ [chromium] › plugins/@nocobase/plugin-action-bulk-edit/src/client/__e2e__/schemaInitailizer.test.ts:14:7 › TableActionInitializers & GanttActionInitializers & MapActionInitializers should add bulk edit action › bulk edit in TableActionInitializers
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/list/__e2e__/schemaInitializer.test.ts:29:7 › where list block can be added › popup
⚠️ [chromium] › plugins/@nocobase/plugin-action-bulk-update/src/client/__e2e__/schemaSettings.test.ts:14:7 › data will be updated && Assign field values && after successful submission › data will be updated && Assign field values && after successful submission

972 passed, 29 skipped
✔️✔️✔️

Full HTML report. Merge workflow run.

@zhangzhonghe zhangzhonghe merged commit 13362da into main May 27, 2024
8 checks passed
@zhangzhonghe zhangzhonghe deleted the T-4348 branch May 27, 2024 04:09
jessetalk added a commit to Ulprotron/nocobase that referenced this pull request May 28, 2024
@jessetalk @estheryo
@actions-user @chareice @zhangzhonghe @zhouyanliang @2013xile @mytharcher
daily merge (#3)
8a709cd 
* Yun002 (#2)

* feat(independent-page): set independent-page

* feat(plugin): add fuzhijia clock plugin

* feat(clock): complete fuzhijia clock

* fix(clock): map issue after refreshing page

* fix(clock): tmap clock issue

* feat(wxcom-auth): add wxcom auth plugin

* fix(merge): merge from main

---------

Co-authored-by: jessetalk <>

* Update README.md

* Update README.zh-CN.md

* Update README.zh-CN.md

* fix:  numeric field display issue in form linkage rule (nocobase#4482)

* fix:  numeric field display issue in form linkage rule

* fix: bug

* chore(versions): 😊 publish v1.0.0-alpha.16

* chore: update changelog

* Update README.md

* Update README.zh-CN.md

* Update README.md

* chore: database prepare error message

* chore: retry in dev env

* refactor: form linkage rule to cancel assignment when multiple fields are selected (nocobase#4492)

* fix: optimize data scope variable in permission configuration (nocobase#4484)

* fix: optimize data scope variable in permission configuration

* test: add e2e test

* chore: fix failed e2e

* fix: optimize data scope variable in permission configuration

* chore: skip weird test

* fix: auto change log

* chore(versions): 😊 publish v1.0.0-alpha.17

* chore: update changelog

* feat: update LICENSE

* fix: sub-table support allowAddNew setting (nocobase#4498)

* chore(auth): change char length limit of username to 1-50 (nocobase#4502)

* fix: fix loss of data scope field in permission configuration

* fix: after update event in single relation repository (nocobase#4503)

* fix: after update event in single relation repository

* test(plugin-workflow): add association collection trigger

---------

Co-authored-by: mytharcher <mytharcher@gmail.com>

* refactor: remove all frontend checks for isForeignKey (nocobase#4499)

* refactor: remove all frontend checks for isForeignKey

* fix: bug

---------

Co-authored-by: estheryo <32948748+estheryo@users.noreply.github.com>
Co-authored-by: Katherine <shunai.tang@hand-china.com>
Co-authored-by: GitHub Actions Bot <actions@github.com>
Co-authored-by: Chareice <chareice@live.com>
Co-authored-by: Zeke Zhang <958414905@qq.com>
Co-authored-by: zhou <zhou.working@gmail.com>
Co-authored-by: YANG QIA <2013xile@gmail.com>
Co-authored-by: mytharcher <mytharcher@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@zhangzhonghe